[release/8.0] Change error to warning for trigger defined on non-base type#32025
Merged
ajcvickers merged 1 commit intorelease/8.0from Oct 12, 2023
Merged
[release/8.0] Change error to warning for trigger defined on non-base type#32025ajcvickers merged 1 commit intorelease/8.0from
ajcvickers merged 1 commit intorelease/8.0from
Conversation
… type Part of #31627 ### Description In EF8, we introduced validation that triggers are not defined on a non-base type in a TPH hierarchy. However, our guidance for configuring triggers on every type violates this. Therefore, we are updating the error to a warning, since having the trigger defined doesn't do much harm and so is likely to have been working in the past. We are also updating the guidance for configuring triggers on every type. ### Customer impact Application that was working in EF7 will throw with EF8. ### How found Customer reported on preview. ### Regression Yes. ### Testing Updated tests. ### Risk Low.
AndriySvyryd
approved these changes
Oct 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #31627
Description
In EF8, we introduced validation that triggers are not defined on a non-base type in a TPH hierarchy. However, our guidance for configuring triggers on every type violates this. Therefore, we are updating the error to a warning, since having the trigger defined doesn't do much harm and so is likely to have been working in the past. We are also updating the guidance for configuring triggers on every type.
Customer impact
Application that was working in EF7 will throw with EF8.
How found
Customer reported on preview.
Regression
Yes.
Testing
Updated tests.
Risk
Low.