Conversation
geeknoid
force-pushed
the
geeknoid/exp
branch
3 times, most recently
from
cf5c52b to
a46831c
Compare
rafal-mz
approved these changes
Jul 17, 2023
geeknoid
force-pushed
the
geeknoid/exp
branch
3 times, most recently
from
9ff2fae to
a87b42d
Compare
RussKie
reviewed
Jul 18, 2023
| @@ -35,9 +35,8 @@ | |||
| <!-- Prevent analyzer crashes from stopping things --> | |||
Contributor
There was a problem hiding this comment.
Lines 19-20 should have been deleted as well
RussKie
reviewed
Jul 18, 2023
Comment on lines
+20
to
+30
| internal const string Resilience = "EXTEXP0001"; | ||
| internal const string Compliance = "EXTEXP0002"; | ||
| internal const string Telemetry = "EXTEXP0003"; | ||
| internal const string TimeProvider = "EXTEXP0004"; | ||
| internal const string AutoClient = "EXTEXP0005"; | ||
| internal const string AsyncState = "EXTEXP0006"; | ||
| internal const string HealthChecks = "EXTEXP0007"; | ||
| internal const string ResourceMonitoring = "EXTEXP0008"; | ||
| internal const string Hosting = "EXTEXP0009"; | ||
| internal const string ObjectPool = "EXTEXP0010"; | ||
| internal const string DocumentDb = "EXTEXP0011"; |
Contributor
There was a problem hiding this comment.
We also need a doc listing all current IDs and explaining which API is each of these IDs light up, if enabled.
The doc should also give guidance on what to do if the ID is encountered - for example, dotnet/aspnetcore has already encountered the TBD warning in the past (dotnet/aspnetcore#49297 (comment)), so once these new IDs flow through what should the maintainers of the repo do. Is it safe to suppress, or should dotnet/aspnetcore rewrite something?
Contributor
|
@geeknoid @rafal-mz we need to do the same for https://github.com/Azure/dotnet-extensions-experimental/ too. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4161
I also deleted a bunch of now useless analyzers (since they exist in the main Roslyn analyzers instead)
Microsoft Reviewers: Open in CodeFlow