[main] Update dependencies from dotnet/command-line-api by dotnet-maestro[bot] · Pull Request #1826 · dotnet/format

dotnet-maestro · 2023-04-27T19:22:03Z

This pull request updates the following dependencies

From https://github.com/dotnet/command-line-api

Subscription: 0977a2e6-6141-4aac-1e76-08d967f4d98f
Build: 20230419.2
Date Produced: April 19, 2023 11:56:36 PM UTC
Commit: 87704ce036fb23a4174b8290f249706aa35ab255
Branch: refs/heads/main

Updates:
- System.CommandLine: from 2.0.0-beta4.22564.1 to 2.0.0-beta4.23219.2
- System.CommandLine.Rendering: from 0.4.0-alpha.22564.1 to 0.4.0-alpha.23219.2

…uild 20230419.2 System.CommandLine , System.CommandLine.Rendering From Version 2.0.0-beta4.22564.1 -> To Version 2.0.0-beta4.23219.2

ghost

Auto-approve

sharwell · 2023-05-01T13:04:16Z

I requested a review from @jonsequitur

sharwell · 2023-05-01T15:46:11Z

@baronfel @adamsitnik would also be able to review this

jonsequitur · 2023-05-04T16:48:11Z

src/Commands/FormatCommandCommon.cs

+        internal static readonly CliOption<string> BinarylogOption = new CliOption<string>("--binarylog")
+        {
+            HelpName = "binary-log-path",
+            Arity = ArgumentArity.ZeroOrOne,


In general, you shouldn't need to set the arity unless there's some custom parsing going on. Otherwise, it's inferred from the generic type of the Option<T> or Argument<T>.

adamsitnik

Overall the changes from @sharwell look great, the only thing we need is to sync the version with dotnet/sdk#33157.

adamsitnik · 2023-06-12T13:01:05Z

eng/Version.Details.xml

      <Sha>d7a4cad21c39e18f3d5e1f7fa7dd3f93668066b4</Sha>
    </Dependency>
-    <Dependency Name="System.CommandLine" Version="2.0.0-beta4.22564.1">
+    <Dependency Name="System.CommandLine" Version="2.0.0-beta4.23219.2">


We need to bump the version to be in sync with dotnet/sdk#33157

Suggested change

<Dependency Name="System.CommandLine" Version="2.0.0-beta4.23219.2">

<Dependency Name="System.CommandLine" Version="2.0.0-beta4.23307.1">

adamsitnik · 2023-06-12T13:01:20Z

eng/Version.Details.xml

+      <Sha>87704ce036fb23a4174b8290f249706aa35ab255</Sha>
    </Dependency>
-    <Dependency Name="System.CommandLine.Rendering" Version="0.4.0-alpha.22564.1">
+    <Dependency Name="System.CommandLine.Rendering" Version="0.4.0-alpha.23219.2">


Suggested change

<Dependency Name="System.CommandLine.Rendering" Version="0.4.0-alpha.23219.2">

<Dependency Name="System.CommandLine.Rendering" Version="0.4.0-alpha.23307.1">

adamsitnik · 2023-06-12T13:01:38Z

eng/Versions.props

+    <SystemCommandLineVersion>2.0.0-beta4.23219.2</SystemCommandLineVersion>
+    <SystemCommandLineRenderingVersion>0.4.0-alpha.23219.2</SystemCommandLineRenderingVersion>


Suggested change

<SystemCommandLineVersion>2.0.0-beta4.23219.2</SystemCommandLineVersion>

<SystemCommandLineRenderingVersion>0.4.0-alpha.23219.2</SystemCommandLineRenderingVersion>

<SystemCommandLineVersion>2.0.0-beta4.23307.1</SystemCommandLineVersion>

<SystemCommandLineRenderingVersion>0.4.0-alpha.23307.1</SystemCommandLineRenderingVersion>

adamsitnik · 2023-06-12T13:01:54Z

eng/Version.Details.xml

+    <Dependency Name="System.CommandLine" Version="2.0.0-beta4.23219.2">
      <Uri>https://github.com/dotnet/command-line-api</Uri>
-      <Sha>350a618ab44932c568ae2392d7a571281baed59a</Sha>
+      <Sha>87704ce036fb23a4174b8290f249706aa35ab255</Sha>


Suggested change

<Sha>87704ce036fb23a4174b8290f249706aa35ab255</Sha>

<Sha>02fe27cd6a9b001c8feb7938e6ef4b3799745759</Sha>

adamsitnik · 2023-06-12T13:02:05Z

eng/Version.Details.xml

+    <Dependency Name="System.CommandLine.Rendering" Version="0.4.0-alpha.23219.2">
      <Uri>https://github.com/dotnet/command-line-api</Uri>
-      <Sha>350a618ab44932c568ae2392d7a571281baed59a</Sha>
+      <Sha>87704ce036fb23a4174b8290f249706aa35ab255</Sha>


Suggested change

<Sha>87704ce036fb23a4174b8290f249706aa35ab255</Sha>

<Sha>02fe27cd6a9b001c8feb7938e6ef4b3799745759</Sha>

adamsitnik · 2023-06-12T15:10:22Z

I don't have the write rights here hence I cannot apply my suggestion or solve the merge conflict

@sharwell is there any chance you could bump the S.CL version and solve the merge conflict?

adamsitnik · 2023-06-12T16:06:50Z

nvm I've sent #1872

baronfel · 2023-06-15T19:26:43Z

Hey @JoeRobich can you revert this? we need to syncronize all the S.CL updates across roslyn/format/runtime/aspnet/sdk/templating and sequence them all together, and since we're getting close to p6 snap we were going to hold until after that snap occurred next week, to prevent too much churn in case we have to back it out across those repos.

JoeRobich · 2023-06-15T20:05:02Z

I knew I should have kept out of it. Will do.

baronfel · 2023-06-15T20:06:21Z

No good deed goes unpunished :) Thanks!

Update dependencies from https://github.com/dotnet/command-line-api b…

4ea7d59

…uild 20230419.2 System.CommandLine , System.CommandLine.Rendering From Version 2.0.0-beta4.22564.1 -> To Version 2.0.0-beta4.23219.2

ghost approved these changes Apr 27, 2023

View reviewed changes

sharwell approved these changes Apr 27, 2023

View reviewed changes

Update to account for API changes

d442f76

jonsequitur reviewed May 4, 2023

View reviewed changes

adamsitnik reviewed Jun 12, 2023

View reviewed changes

adamsitnik mentioned this pull request Jun 12, 2023

Port existing dotnet org applications to latest version of System.CommandLine dotnet/command-line-api#2146

Closed

5 tasks

This was referenced Jun 12, 2023

Revert "Revert "[main] Update dependencies from dotnet/command-line-api (#29131)"" dotnet/sdk#33157

Merged

System.CommandLine update #1872

Merged

JoeRobich merged commit 51b963f into main Jun 15, 2023

ghost added this to the Next milestone Jun 15, 2023

dotnet-maestro bot deleted the darc-main-e24473e8-6950-4d67-aabf-025da8dc8ea2 branch June 15, 2023 19:25

	<Dependency Name="System.CommandLine" Version="2.0.0-beta4.23219.2">
	<Dependency Name="System.CommandLine" Version="2.0.0-beta4.23307.1">

	<Dependency Name="System.CommandLine.Rendering" Version="0.4.0-alpha.23219.2">
	<Dependency Name="System.CommandLine.Rendering" Version="0.4.0-alpha.23307.1">

		<SystemCommandLineVersion>2.0.0-beta4.23219.2</SystemCommandLineVersion>
		<SystemCommandLineRenderingVersion>0.4.0-alpha.23219.2</SystemCommandLineRenderingVersion>

	<Sha>87704ce036fb23a4174b8290f249706aa35ab255</Sha>
	<Sha>02fe27cd6a9b001c8feb7938e6ef4b3799745759</Sha>

Conversation

dotnet-maestro bot commented Apr 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

From https://github.com/dotnet/command-line-api

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

sharwell commented May 1, 2023

Uh oh!

sharwell commented May 1, 2023

Uh oh!

jonsequitur May 4, 2023

Choose a reason for hiding this comment

Uh oh!

adamsitnik left a comment

Choose a reason for hiding this comment

Uh oh!

adamsitnik Jun 12, 2023

Choose a reason for hiding this comment

Uh oh!

adamsitnik Jun 12, 2023

Choose a reason for hiding this comment

Uh oh!

adamsitnik Jun 12, 2023

Choose a reason for hiding this comment

Uh oh!

adamsitnik Jun 12, 2023

Choose a reason for hiding this comment

Uh oh!

adamsitnik Jun 12, 2023

Choose a reason for hiding this comment

Uh oh!

adamsitnik commented Jun 12, 2023

Uh oh!

adamsitnik commented Jun 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

baronfel commented Jun 15, 2023

Uh oh!

JoeRobich commented Jun 15, 2023

Uh oh!

baronfel commented Jun 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dotnet-maestro bot commented Apr 27, 2023 •

edited

Loading

adamsitnik commented Jun 12, 2023 •

edited

Loading