Skip to content

Conversation

@JoeRobich
Copy link
Member

The latest version of System.CommandLine supports loading options via response files. This could be our solution to the request to support a configuration file (#520).

@JoeRobich
Copy link
Member Author

@jmarolf PTAL


namespace Microsoft.CodeAnalysis.Tools.Logging
{
internal class NullScope : IDisposable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this used for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used by the Loggers. It used to be a public type but has disappeared from the new version of the library.

Copy link
Contributor

@jmarolf jmarolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JoeRobich JoeRobich merged commit 4b3b782 into dotnet:master Feb 16, 2020
@JoeRobich JoeRobich deleted the update-versions branch March 5, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants