Upgrade SB build leg from Ubuntu 20.04 to Ubuntu 22.04#16901
Merged
mthalman merged 2 commits intodotnet:mainfrom Jul 6, 2023
Merged
Upgrade SB build leg from Ubuntu 20.04 to Ubuntu 22.04#16901mthalman merged 2 commits intodotnet:mainfrom
mthalman merged 2 commits intodotnet:mainfrom
Conversation
MichaelSimons
approved these changes
Jul 6, 2023
| centOSStream9Container: mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream9 | ||
| fedora38Container: mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-38 | ||
| ubuntu2004Container: mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-20.04 | ||
| ubuntu2204Container: mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04 |
Member
There was a problem hiding this comment.
What do you think about updating the comment above the container parameters to remind folks that when updating, corresponding changes are needed in the diff pipeline?
Member
Author
There was a problem hiding this comment.
I'm actually more inclined to put such a comment next to the buildName parameter for each job. I think it's more likely to be noticed there, and more relevant positioning.
MichaelSimons
approved these changes
Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runtime repo is failing to build in the Ubuntu 20.04 leg of the VMR due to this error:
This happens because the minimum required version of CMake has been upgraded to 3.20. But the CMake version in Ubuntu 20.04 is at 3.16.3.
Fixing this by upgrading the version to Ubuntu 22.04 which has the required CMake version.