[Java.Interop.Tools.TypeNameMappings] fix ToJniName()

[jonathanpeppers]

The following test in xamarin/xamarin-android:

[Test]
public void NewObjectArrayWithNonJavaTypeAndEmptyArray ()
{
    //empty array gives the right type
    var array = JNIEnv.NewObjectArray<Type> (new Type [0]);

Throws with:

Java.Lang.ClassNotFoundException : crc64d04135c992393d83.Type
----> Java.Lang.ClassNotFoundException : Didn't find class "crc64d04135c992393d83.Type" on path: DexPathList[[zip file "/data/app/Mono.Android.NET_Tests-VrfrXDHT2r32zDG95kFOiw==/base.apk", zip file "/data/app/Mono.Android.NET_Tests-VrfrXDHT2r32zDG95kFOiw==/split_config.x86_64.apk", zip file "/data/app/Mono.Android.NET_Tests-VrfrXDHT2r32zDG95kFOiw==/split_config.xxhdpi.apk"],nativeLibraryDirectories=[/data/app/Mono.Android.NET_Tests-VrfrXDHT2r32zDG95kFOiw==/lib/x86_64, /data/app/Mono.Android.NET_Tests-VrfrXDHT2r32zDG95kFOiw==/base.apk!/lib/x86_64, /data/app/Mono.Android.NET_Tests-VrfrXDHT2r32zDG95kFOiw==/split_config.x86_64.apk!/lib/x86_64, /data/app/Mono.Android.NET_Tests-VrfrXDHT2r32zDG95kFOiw==/split_config.xxhdpi.apk!/lib/x86_64, /system/lib64, /system/product/lib64]]

It turns out, this type is completely wrong? It should be looking for java/lang/Object instead?

In 56b7eeb, we lost an important detail from the expression:

if (!type.GetInterfaces ().Any (t => t.FullName == "Android.Runtime.IJavaObject"))

We are missing the ! !!!

I was able to reproduce this behavior in a test:

[Test]
[TestCase (typeof (System.Type), "java/lang/Object")]
public void ToJniName (Type type, string expected)
{
    string actual = JavaNativeTypeManager.ToJniName (type);
    Assert.AreEqual (expected, actual);
}

Where ToJniName() was returning crc64d04135c992393d83/Type instead of java/lang/Object! After fixing the problem, the test passes.

[jonathanpeppers]

I updated dotnet/android#8751, to test this.