TextLoader now checks for presence of source file with clear error message#4665
Merged
mstfbl merged 7 commits intodotnet:masterfrom Jan 29, 2020
Merged
TextLoader now checks for presence of source file with clear error message#4665mstfbl merged 7 commits intodotnet:masterfrom
mstfbl merged 7 commits intodotnet:masterfrom
Conversation
yaeldekel
reviewed
Jan 20, 2020
src/Microsoft.ML.Data/DataLoadSave/Text/TextLoaderSaverCatalog.cs
Outdated
Show resolved
Hide resolved
yaeldekel
reviewed
Jan 26, 2020
The constructor should throw an exception when trying to load from a fake/missing file.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #2461
TextLoader now checks whether the given file in path exists. If the file is missing, a clear exception stating that the file is missing is given, instead of stating that some field is missing some unknown attribute.