Updated constructor of ImageLoadingTransformer to accept empty imageFolder paths#4976
Merged
mstfbl merged 3 commits intodotnet:masterfrom Mar 27, 2020
Merged
Conversation
justinormont
approved these changes
Mar 26, 2020
harishsk
approved these changes
Mar 26, 2020
natke
reviewed
Mar 26, 2020
Contributor
natke
left a comment
natke
left a comment
There was a problem hiding this comment.
Looks good! Do we have a unit test for this class?
…orrect imageFolder paths
Contributor
Author
|
@natke Yup, just added! :D |
kere-nel
reviewed
Mar 26, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain ML.NET/ONNX samples, the provided path for the directory containing images for loading may be empty, and output the following exception:
This PR is so that the provided imageFolder path that is provided to the constructor of
ImageLoadingTransformermay be null or empty.