Use Append for not format string#5826
Merged
michaelgsharp merged 1 commit intodotnet:mainfrom Jun 8, 2021
feiyun0112:patch11
Merged
Use Append for not format string#5826michaelgsharp merged 1 commit intodotnet:mainfrom feiyun0112:patch11
michaelgsharp merged 1 commit intodotnet:mainfrom
feiyun0112:patch11
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5826 +/- ##
==========================================
- Coverage 68.37% 68.32% -0.05%
==========================================
Files 1131 1131
Lines 241291 241291
Branches 25053 25053
==========================================
- Hits 164993 164873 -120
- Misses 69806 69916 +110
- Partials 6492 6502 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eerhardt
approved these changes
Jun 3, 2021
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
@michaelgsharp - it might be helpful to turn on more roslyn analyzers in dotnet/machinelearning so these things are checked and don't regress on new code.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.