[dotnet-linker] Export DOTNET for csproj.inc generation.#24852
[dotnet-linker] Export DOTNET for csproj.inc generation.#24852rolfbjarne merged 2 commits intomainfrom
Conversation
The create-makefile-fragment.sh script requires the DOTNET environment variable to be set. The previous BUILD_EXECUTABLE export was removed in 9cf7f59, but the replacement DOTNET export was not added, causing the Linux build to fail because the .csproj.inc file couldn't be generated, which meant ProductConstants.cs wasn't generated either. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Fixes Linux builds where dotnet-linker.csproj.inc (and downstream generated sources like ProductConstants.cs) fails to generate because create-makefile-fragment.sh requires the DOTNET environment variable.
Changes:
- Export
DOTNETfor thedotnet-linker.csproj.incmake target socreate-makefile-fragment.shcan run successfully.
You can also share your feedback on Copilot code review. Take the survey.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #9040ba1] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #9040ba1] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #9040ba1] Build passed (Build macOS tests) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #9040ba1] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 156 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
The create-makefile-fragment.sh script requires the DOTNET environment
variable to be set. The previous BUILD_EXECUTABLE export was removed in
9cf7f59, but the replacement DOTNET export was not added, causing the
Linux build to fail because the .csproj.inc file couldn't be generated,
which meant ProductConstants.cs wasn't generated either.