Fix docs/bindas.md links pointing to personal fork instead of dotnet/macios#25441
Open
rolfbjarne wants to merge 1 commit into
Open
Fix docs/bindas.md links pointing to personal fork instead of dotnet/macios#25441rolfbjarne wants to merge 1 commit into
rolfbjarne wants to merge 1 commit into
Conversation
…l fork Update all 11 code reference links ([1]-[7], [9]-[12]) in docs/bindas.md to use the canonical dotnet/macios repository with a permalink SHA instead of the rolfbjarne/xamarin-macios personal fork. Also update links [11] and [12] to reference the renamed file path src/bgen/Generator.cs (previously src/generator.cs), and correct all line numbers to match the current state of the codebase. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This documentation-only PR updates docs/bindas.md code-reference links from a personal fork to canonical dotnet/macios permalinks.
Changes:
- Replaces fork-based GitHub URLs with
dotnet/macioscommit permalinks. - Updates referenced paths and line targets, including renamed
src/bgen/Generator.cs.
Comments suppressed due to low confidence (1)
docs/bindas.md:52
- The static registrar link targets were updated to lines 4896 and 4925, but the prose still displays
StaticRegistrar.cs#3796andStaticRegistrar.cs#3830. Please update the visible link text too so readers do not see stale line numbers.
[9]: https://github.com/dotnet/macios/blob/18a22fd0812016cfdc8397d9b70981a1fc365fed/tools/common/StaticRegistrar.cs#L4896
[10]: https://github.com/dotnet/macios/blob/18a22fd0812016cfdc8397d9b70981a1fc365fed/tools/common/StaticRegistrar.cs#L4925
Comment on lines
+44
to
+49
| [2]: https://github.com/dotnet/macios/blob/18a22fd0812016cfdc8397d9b70981a1fc365fed/runtime/xamarin/trampolines.h#L197 | ||
| [3]: https://github.com/dotnet/macios/blob/18a22fd0812016cfdc8397d9b70981a1fc365fed/runtime/trampolines.m#L1252 | ||
| [4]: https://github.com/dotnet/macios/blob/18a22fd0812016cfdc8397d9b70981a1fc365fed/runtime/xamarin/trampolines.h#L161 | ||
| [5]: https://github.com/dotnet/macios/blob/18a22fd0812016cfdc8397d9b70981a1fc365fed/runtime/trampolines.m#L1192 | ||
| [6]: https://github.com/dotnet/macios/blob/18a22fd0812016cfdc8397d9b70981a1fc365fed/runtime/trampolines.m#L1601-L1602 | ||
| [7]: https://github.com/dotnet/macios/blob/18a22fd0812016cfdc8397d9b70981a1fc365fed/src/ObjCRuntime/Registrar.cs#L794 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 11 numbered code reference links in
docs/bindas.md(links [1]–[7], [9]–[12]) pointed to a personal fork (rolfbjarne/xamarin-macios) at a specific commit SHA. These links are not guaranteed to remain accessible. Link [8] (a PR link) was already correct.This PR updates all 11 links to use canonical
dotnet/maciospermalinks with the current main branch SHA (18a22fd), with corrected line numbers matching the current state of the codebase.Changes
rolfbjarne/xamarin-macios/blob/b38c114f…→dotnet/macios/blob/18a22fd0…src/generator.cs→src/bgen/Generator.cs(file was renamed)testgenerator.cs#L100→#L125,Registrar.cs#L687→#L794)Verification
All 11 updated URLs return HTTP 200. This is a documentation-only change with no code impact.