MauiIcon ForegroundScale does not work on development machines that use a comma as a decimal seperator

[AndreKraemer]

Description

According to the docs at https://learn.microsoft.com/en-us/dotnet/maui/user-interface/images/app-icons?view=net-maui-7.0&tabs=android you can use the ForegroundScale Attribute of the MauiIcon element so scale your foreground layer like this:
<MauiIcon Include="Resources\AppIcon\appicon.svg" ForegroundFile="Resources\AppIcon\appiconfg.svg" ForegroundScale="0.65" Color="#512BD4" />

This works fine if the decimal separator is a dot on your operating system's regional settings. If your operating system's regional settings use a comma as a decimal separator (like in most european countries), the image will, however not be scaled down if you use ForegroundScale="0.65", but instead, it will be scaled up.

Because of this, the foreground of the generated icon will never fit into the background.

Steps to Reproduce

1. Create a File > New MAUI App on system that uses a comma as a decimal seperator
2. Open the .csproj file and add ForegroundScale="0.65" to the MauiIcon element
3. Run the app on Android or Windows
4. You can't see the ".NET" text in the icon any more

Link to public reproduction project repository

https://github.com/AndreKraemer/MauiIconScalingIssue

Version with bug

7.0 (current)

Last version that worked well

Unknown/Other

Affected platforms

Android

Affected platform versions

Android 13, Windows 10, Windows 11

Did you find any workaround?

You can use a comma as separator for the ForegroundScale attribute like this ForegroundScale="0,65". This will work if your dev system uses a comma as a decimal separator, but will break on systems that use a dot as a separator)

Relevant log output

No response

[AndreKraemer]

Some additional Info: I ran the Resizetizer:unitTests on my system. 40 Tests are failing because of this issue:

• Multiple variations of: Microsoft.Maui.Resizetizer.Tests.ResizetizeImagesTests+ExecuteForAndroid.DiffPropoprtionAppIconWithoutBaseUseBackgroundSize(fgScale: 0,5, bg: "dotnet_background.svg", fg: "tall_image.png")
• Multiple variations of: Microsoft.Maui.Resizetizer.Tests.ResizetizeImagesTests+ExecuteForAndroid.MultipleAppIconGeneratesCorrectFilesWithForegroundScale(filename: "camera.png", colorString: "#00FF00", tintColorString: "#00FF00")
• Multiple variations of: Microsoft.Maui.Resizetizer.Tests.ResizetizeImagesTests+ExecuteForAndroid.SingleAppIconGeneratesCorrectFilesWithForegroundScale(filename: "camera.png", colorString: "#00FF00", tintColorString: "#00FF00")

The error messages are all similar to this one:
Image was not equal. Error was 0,8156721536351166% (2422186 pixels)

The actual bug is in line 99 of :
\src\SingleProject\Resizetizer\src\ResizeImageInfo.cs
if (float.TryParse(image.GetMetadata("ForegroundScale"), out var fsc))

it should be
if (float.TryParse(image.GetMetadata("ForegroundScale"), NumberStyles.Number, CultureInfo.InvariantCulture, out var fsc))
instead.

After the change all the unit tests of Resisetizer are green on my machine.
I'll try to create a PR

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.