[XSG] Improve diagnostic reporting during binding compilation (#32905) - [x] Analyze the issue - understand TODOs in binding compilation logic - [x] Identify files to modify: `CompiledBindingMarkup.cs`, `KnownMarkups.cs`, `Descriptors.cs`, `MauiGResources.resx`, etc. - [x] Build and test baseline (100 tests passing) - [x] Add new diagnostic descriptors for binding-related errors (matching XamlC error codes) - MAUIG2041: BindingIndexerNotClosed (matching XC0041) - MAUIG2042: BindingIndexerEmpty (matching XC0042) - MAUIG2043: BindingIndexerTypeUnsupported (matching XC0043) - MAUIG2045: BindingPropertyNotFound (matching XC0045) - MAUIG2024: BindingWithXDataTypeFromOuterScope warning (matching XC0024) - MAUIG2064: NamescopeDuplicate (matching XC0064) - [x] Replace `return false; // TODO report diagnostic` with actual diagnostic reporting - [x] Replace `throw new Exception` with diagnostic reporting - [x] Update resource strings to match XamlC messages - [x] Add unit tests for the new diagnostics (6 tests) - [x] Update AnalyzerReleases.Unshipped.md - [x] Build and test (147 tests passing) - [x] Run code review and address feedback - [x] Run CodeQL checker (no security issues found) - [x] Revert unrelated formatting changes - [x] Fix alignment in Descriptors.cs - [x] Change diagnostic prefix from MAUIX to MAUIG per reviewer feedback - [x] Remove unreachable code in CompiledBindingMarkup.cs - [x] Add missing test scenarios for MAUIG2024 and MAUIG2043 diagnostics - [x] Support NoWarn metadata for source generator diagnostics - [x] Add MAUIG2045 to NoWarn for test XAML files with intentional binding errors - [x] Address latest code review feedback: - Refactored repeated indexer lookup pattern into reusable local function - Removed localized message checks from diagnostic tests - Fixed IndexerBindings test assertions to properly validate lambda context using regex patterns that match actual generated code structure

Original prompt

> > ---- > > *This section details on the original issue you should resolve* > > [XSG] Improve diagnostic reporting during binding compilation > We left several todos in the binding compilation logic in the XAML source generator. We should try to match the warnings and errors produced by XamlC, just with an adjusted error code. > > ## Comments on the Issue (you are @copilot in this section) > > > >

- Fixes dotnet/maui#32904 --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com> Co-authored-by: Simon Rozsival

[XSG] Improve diagnostic reporting during binding compilation #32904

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions