Allow Button.ImageSource to be updated on Android, iOS and macOS#11008
Closed
espenrl wants to merge 2 commits intodotnet:mainfrom
Closed
Allow Button.ImageSource to be updated on Android, iOS and macOS#11008espenrl wants to merge 2 commits intodotnet:mainfrom
espenrl wants to merge 2 commits intodotnet:mainfrom
Conversation
ghost
added
the
|
Hey there @espenrl! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Eilon
added
the
legacy-area-controls
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
It may have been resolved by #11146 I´m not sure if it´s the same issue or not. |
Member
|
@espenrl have you verified if this is indeed still an issue or that this has been fixed by more recent releases? |
Contributor
Author
|
This is fixed in .NET 7 SR2 |
Eilon
added
area-controls-button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current implementation
Button.ImageSourceonly reacts to updates onWindows. This PR add support for Android, iOS and macOS.Tizen support
Tizen should probably also be supported. But given that I don't have a setup to test Tizen I have not implemented it.
A note on Image and ImageButton
Image and ImageButton is verified to NOT have the problem.