Skip to content

[iOS] Don't set constraints for orientation if they are 0 #14143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rmarinho wants to merge 1 commit into from
Closed

[iOS] Don't set constraints for orientation if they are 0 #14143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Core/src/Handlers/ScrollView/ScrollViewHandler.iOS.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,12 +314,12 @@ static Size SetContentSizeForOrientation(UIScrollView platformScrollView, Scroll

internal static Size AccountForOrientation(Size size, double widthConstraint, double heightConstraint, ScrollOrientation orientation)
{
if (orientation is ScrollOrientation.Vertical or ScrollOrientation.Neither)
if (orientation is ScrollOrientation.Vertical or ScrollOrientation.Neither && widthConstraint > 0)
{
size.Width = widthConstraint;
}

if (orientation is ScrollOrientation.Horizontal or ScrollOrientation.Neither)
if (orientation is ScrollOrientation.Horizontal or ScrollOrientation.Neither && heightConstraint > 0)
{
size.Height = heightConstraint;
}
Expand Down