Allows support for other default browsers on Android to work with the Web Authenticator#15278
Closed
vhugogarcia wants to merge 1 commit intodotnet:mainfrom
Closed
Conversation
|
Hey there @vhugogarcia! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
MartyIX
reviewed
May 26, 2023
| base.OnResume(); | ||
|
|
||
| if (!launched) | ||
| if (actualIntent != null && !launched) |
Contributor
There was a problem hiding this comment.
Suggested change
| if (actualIntent != null && !launched) | |
| if (actualIntent is not null && !launched) |
Member
Contributor
Author
|
Thanks @mattleibow for the heads-up. Happy to see it has been fixed fully. Please back-port that issue to .NET MAUI 7 service release. We are facing this issue with our apps and it will be good 🙏 to have it fix. Thanks again 😎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
When a browser different from Chrome is assigned as default in Android, the web authenticator throws an exception with some browsers only.
This change prevents NullReferenceException on WebAuthenticatorIntermediateActivity.android.cs and allows support for other default browsers on Android to work with the Web Authenticator, and continue the authentication flow.
This change has been tested with the following browsers:
Issues Fixed
Fixes #13798