Skip to content

[C] Replace value with same specificity #17365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 1 commit into from
Sep 14, 2023
Merged

[C] Replace value with same specificity #17365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Controls/src/Core/BindableObject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ internal void SetBinding(BindableProperty targetProperty, BindingBase binding, S
{
var kvp = context.Values.Last();
context.Values.Remove(kvp.Key);
context.Values.Add(SetterSpecificity.FromBinding, kvp.Value);
context.Values[SetterSpecificity.FromBinding] = kvp.Value;
Copy link
Copy Markdown
Contributor

@jsuarezruiz jsuarezruiz Sep 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To test it can use any Style with a Binding property?

Copy link
Copy Markdown
Contributor Author

@StephaneDelcroix StephaneDelcroix Sep 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, without a test case, we do not know if the issue is related setter and style. that hypothesis was only me guessing. So I can't add a test for this issue as we don't know what the issue is.

What we have is a stack trace, and we can (and did) fix the code so that error no longer fire

}

context.Binding?.Unapply();
Expand Down