RadioButton being Garbage Collected#20472
Closed
jsuarezruiz wants to merge 5 commits into
Closed
Conversation
jsuarezruiz
added
platform/ios
legacy-area-perf
ghost
added
the
legacy-area-controls
PureWeen
reviewed
Feb 10, 2024
| get | ||
| { | ||
| if (s_defaultTemplate == null) | ||
| ControlTemplate defaultTemplate = null; |
Member
There was a problem hiding this comment.
Did you narrow down to what was leaking? I worry that fixing this via the ControlTemplate is just fixing a symptom instead of the cause. For example, if something in the template is leaking this will probably fix it but we probably want to fix that leak instead.
For example, if you just set the datatemplate to something really boring does it still leak?
Member
There was a problem hiding this comment.
Yeah so it looks like part of the memory leak occurs here in the BuildDefaultTemplate method:
border.SetBinding(Border.StrokeShapeProperty,
new Binding(CornerRadiusProperty.PropertyName, converter: new CornerRadiusToShape(),
source: RelativeBindingSource.TemplatedParent));
Member
|
Noticed the test didn't pass, I don't think this PR will fix it as these are the underlying issues: #20023 (comment) |
Contributor
Author
|
Close in favor of #21151 |
Eilon
added
perf/general
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
RadioButton being Garbage Collected on iOS.
Issues Fixed
Fixes #20023