Merged
Conversation
ghost
added
the
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jsuarezruiz
added
platform/ios
area-controls-shell
jsuarezruiz
reviewed
Feb 12, 2024
kubaflo
force-pushed
the
ios-shell-toolbar-items
branch
2 times, most recently
from
8b99988 to
88f89b4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
When could be this ready to test with nightly builds... ? |
This comment was marked as outdated.
This comment was marked as outdated.
jsuarezruiz
reviewed
Jun 11, 2024
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18946.cs
Outdated
Show resolved
Hide resolved
Contributor
|
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
|
When could be this ready for release? |
kubaflo
force-pushed
the
ios-shell-toolbar-items
branch
from
af7e29e to
9639650
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
@jfversluis / @StephaneDelcroix any idea when this will be ready? |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
kubaflo
force-pushed
the
ios-shell-toolbar-items
branch
from
9639650 to
3112503
Compare
kubaflo
force-pushed
the
ios-shell-toolbar-items
branch
from
3112503 to
9195f90
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Azure Pipelines successfully started running 3 pipeline(s). |
jfversluis
approved these changes
Dec 20, 2024
|
Is the fix going to be in .NET 9 and not in .NET 8 |
Contributor
Author
|
@sabrigo yes, the fix will be only in .NET 9 |
|
Can this fix be pushed to .net 8 as well? as .NET 8 is still LTS, shouldn't be covered there as well. Plus, I raised this issue on .NET 8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Enabled displaying toolbar items declared in the
<Shell.ToolbarItems>Issues Fixed
Fixes #18946