Skip to content

[Android] Page.IsBusy activity indicators gets stuck/causes multiple to be displayed#23745

Merged
rmarinho merged 2 commits intodotnet:mainfrom
kubaflo:issue-23674
Nov 18, 2024
Merged

[Android] Page.IsBusy activity indicators gets stuck/causes multiple to be displayed#23745
rmarinho merged 2 commits intodotnet:mainfrom
kubaflo:issue-23674

Conversation

@kubaflo
Copy link
Copy Markdown
Contributor

@kubaflo kubaflo commented Jul 21, 2024

Issues Fixed

Fixes #23674

After Before
Screen.Recording.2024-07-21.at.16.41.11.mov
Screen.Recording.2024-07-21.at.16.45.02.mov

@kubaflo kubaflo requested a review from a team as a code owner July 21, 2024 14:48
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jul 21, 2024
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

dotnet-policy-service bot commented Jul 21, 2024

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@kubaflo kubaflo added platform/android area-navigation NavigationPage and removed community ✨ Community Contribution labels Jul 21, 2024
@jsuarezruiz
Copy link
Copy Markdown
Contributor

jsuarezruiz commented Oct 23, 2024

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Oct 23, 2024

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Copy Markdown
Contributor

jsuarezruiz commented Oct 23, 2024

Triggered build to generate test snapshots.

@jsuarezruiz
Copy link
Copy Markdown
Contributor

jsuarezruiz commented Oct 29, 2024

/rebase

@jsuarezruiz
Copy link
Copy Markdown
Contributor

jsuarezruiz commented Oct 31, 2024

/azp run

@dotnet dotnet deleted a comment from azure-pipelines bot Oct 31, 2024
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Oct 31, 2024

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Copy Markdown
Contributor

jsuarezruiz commented Oct 31, 2024

Potentially could fix #25585

@jsuarezruiz
Copy link
Copy Markdown
Contributor

jsuarezruiz commented Nov 13, 2024

/rebase

@jsuarezruiz
Copy link
Copy Markdown
Contributor

jsuarezruiz commented Nov 13, 2024

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Nov 13, 2024

Azure Pipelines successfully started running 3 pipeline(s).

rmarinho
rmarinho requested changes Nov 16, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-11-15 at 16 44 01

Seems it s always failing this 2 UITests

@kubaflo
Copy link
Copy Markdown
Contributor Author

kubaflo commented Nov 16, 2024

@albyrock87 and I noticed that @rmarinho these 2 test fails for other PRs too. For example in this @albyrock87's PR https://dev.azure.com/xamarin/public/_build/results?buildId=128205&view=ms.vss-test-web.build-test-results-tab&runId=3368660&resultId=100075&paneView=debug

The issue is that the screenshotS generated by the pipeline are different that what we can see locally:

Locally:

CI:

@jsuarezruiz
Copy link
Copy Markdown
Contributor

jsuarezruiz commented Nov 18, 2024

@albyrock87 and I noticed that @rmarinho these 2 test fails for other PRs too. For example in this @albyrock87's PR https://dev.azure.com/xamarin/public/_build/results?buildId=128205&view=ms.vss-test-web.build-test-results-tab&runId=3368660&resultId=100075&paneView=debug

The issue is that the screenshotS generated by the pipeline are different that what we can see locally:

Locally:

CI:

That tests will change and will be fixed in another PR.

@rmarinho rmarinho merged commit f33c9a4 into dotnet:main Nov 18, 2024
@samhouts samhouts added fixed-in-9.0.21 fixed-in-net8.0-nightly This may be available in a nightly release! labels Dec 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rmarinho rmarinho rmarinho approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix was automatically assigned from dotnet/dotnet-maui-reviewers

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 was automatically assigned from dotnet/dotnet-maui-reviewers

+1 more reviewer

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-navigation NavigationPage fixed-in-9.0.21 fixed-in-net8.0-nightly This may be available in a nightly release! platform/android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Page.IsBusy activity idicators gets stuck/causes multiple to be displayed

4 participants

@kubaflo @jsuarezruiz @rmarinho @samhouts