Conversation
mattleibow
approved these changes
Aug 6, 2024
mattleibow
reviewed
Aug 6, 2024
Comment on lines
+31
to
+35
| #if ANDROID | ||
| // This is a temporary workaround for Android so that images don't just keep vanishing | ||
| // We will have a better fix in the next release that's better integrated with Glide | ||
| internal bool CheckForImageLoadedOnAttached { get; set; } | ||
| #endif |
Member
There was a problem hiding this comment.
Can we get an issue assigned to something so this does not haunt us forever?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This is a simplified down version of #23830. Glide monitors the life cycle of the fragment that it is contained in. If the fragment is paused or stopped it will dispose of the bitmap and set the drawable on the image to null. This PR checks to see if an ImageView should have a drawable when it's being reattached to the window. If it should, then it refires the image loading code so that
Glidecan reload the image.We should fix this more completely in the Glide layer, but, for now this will at least fix a really nasty bug with images.
Issues Fixed
Fixes #14471