Enhanced Stepper to Support Dynamic Increment Mapping#24396
Merged
mattleibow merged 33 commits intodotnet:mainfrom Jan 24, 2025
Merged
Enhanced Stepper to Support Dynamic Increment Mapping#24396mattleibow merged 33 commits intodotnet:mainfrom
mattleibow merged 33 commits intodotnet:mainfrom
Conversation
…le in MVVM context (Windows)
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
requested changes
Aug 26, 2024
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
requested changes
Sep 5, 2024
Member
PureWeen
left a comment
PureWeen
left a comment
There was a problem hiding this comment.
ChangeIncrementValue failing
Contributor
Author
|
Hi @PureWeen , |
Member
|
Needs rebase |
Contributor
|
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mattleibow
requested changes
Jan 15, 2025
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
mattleibow
reviewed
Jan 22, 2025
Member
mattleibow
left a comment
mattleibow
left a comment
There was a problem hiding this comment.
This is looking great. Just a note on a small improvement to the test code.
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20706.cs
Outdated
Show resolved
Hide resolved
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
When the Stepper value is updated dynamically, the current increment value is not correctly passed to the PlatformView. This issue occurs because the Interval property, which controls the stepper's increment, is not mapped properly to the PlatformView. As a result, the expected behavior of incrementing the stepper value is not consistent.
Description of Change
Implemented the AppendToMapping mechanism for the StepperHandler to properly map the Increment property to the platform-specific views.Additionally, the MapInterval method was implemented across all supported platforms to ensure the UpdateIncrement method is called appropriately, enabling the platform views to reflect the dynamically updated increment value consistently.
Issues Fixed
Fixes #20706
Validated the behaviour in the following platforms
Output Screenshot
Before Changes
357055938-668993ec-532d-43b4-8b1a-47b98c8ec077.mp4
After Changes
357056346-be60183c-883c-4f72-a49c-06c9f3d6b489.mp4