BarBackground with Brush in NavigationPage on theme change#24429
Merged
PureWeen merged 6 commits intodotnet:mainfrom Jan 9, 2025
Merged
BarBackground with Brush in NavigationPage on theme change#24429PureWeen merged 6 commits intodotnet:mainfrom
PureWeen merged 6 commits intodotnet:mainfrom
Conversation
kubaflo
added
area-navigation
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jonpryor
added
platform/android
and removed
partner/android
Contributor
|
/rebase |
github-actions
bot
force-pushed
the
fix-24428
branch
from
043a472 to
456816d
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
previously requested changes
Nov 13, 2024
...rols/tests/TestCases.Android.Tests/snapshots/android/NavigationBarBackgroundShouldChange.png
Show resolved
Hide resolved
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
@kubaflo Could you rebase and fix the conflict? Thanks in advance. |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/rebase |
Contributor
There was a problem hiding this comment.
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (1)
- src/Controls/tests/TestCases.HostApp/Issues/Issue24428.xaml: Language not supported
Comments suppressed due to low confidence (2)
src/Controls/src/Core/Compatibility/Handlers/NavigationPage/iOS/NavigationRenderer.cs:39
- [nitpick] The variable name _currentBarBackgroundBrush is clear and consistent with existing naming conventions.
Brush _currentBarBackgroundBrush;
src/Controls/src/Core/Compatibility/Handlers/NavigationPage/iOS/NavigationRenderer.cs:268
- Ensure that the new behavior introduced in UpdateBarBackground and RefreshBarBackground is covered by tests.
if(_currentBarBackgroundBrush is GradientBrush gb)
ceb0ade to
b511f6e
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
mattleibow
reviewed
Jan 6, 2025
Member
mattleibow
left a comment
mattleibow
left a comment
There was a problem hiding this comment.
Looking good, I think we can add a verify for the initial light mode just in case something breaks and CI suddenly goes dark mode by default. #defensivetesting
mattleibow
previously approved these changes
Jan 6, 2025
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/azp run |
PureWeen
approved these changes
Jan 7, 2025
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
requested changes
Jan 8, 2025
Member
PureWeen
left a comment
PureWeen
left a comment
There was a problem hiding this comment.
NavigationBarBackgroundShouldChange is failing on android
Contributor
There was a problem hiding this comment.
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- src/Controls/tests/TestCases.HostApp/Issues/Issue24428.xaml: Language not supported
Comments suppressed due to low confidence (2)
src/Controls/src/Core/Toolbar/Toolbar.Android.cs:108
- Ensure that the new UpdateBarBackground method is covered by tests in TestCases.Shared.Tests.
void UpdateBarBackground()
src/Controls/src/Core/Compatibility/Handlers/NavigationPage/iOS/NavigationRenderer.cs:723
- The new behavior introduced in OnBarBackgroundChanged is not covered by tests. Ensure that this method is tested to verify the functionality.
void OnBarBackgroundChanged(object sender, EventArgs e)
src/Controls/src/Core/Compatibility/Handlers/NavigationPage/iOS/NavigationRenderer.cs
Show resolved
Hide resolved
src/Controls/src/Core/Compatibility/Handlers/NavigationPage/iOS/NavigationRenderer.cs
Show resolved
Hide resolved
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #24428
Screen.Recording.2024-08-26.at.01.04.52.mov