Fix for unable to select a tab after backing out of a page and returning.#25011
Merged
PureWeen merged 11 commits intodotnet:mainfrom Jan 15, 2025
Merged
Fix for unable to select a tab after backing out of a page and returning.#25011PureWeen merged 11 commits intodotnet:mainfrom
PureWeen merged 11 commits intodotnet:mainfrom
Conversation
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
@PureWeen, Unfortunately, I'm unable to include a test case for the fix, as it's not possible to add an automation ID for the tab title. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
Added UITest. |
Contributor
|
/azp-run |
Contributor
Author
@jsuarezruiz, Thank you for your effort in adding and committing the test case for this complex scenario. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
requested changes
Oct 25, 2024
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Nov 4, 2024
Contributor
|
/azp run |
Contributor
|
/rebase |
…elected property of the CurrentPage.
…opertyChanged for IsSelected.
github-actions
bot
force-pushed
the
fix-24741
branch
from
2e45d83 to
dfc1643
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/rebase |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
|
/rebase |
sheiksyedm
added
the
partner/syncfusion
Contributor
Author
|
/rebase |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Foda
approved these changes
Jan 6, 2025
PureWeen
approved these changes
Jan 15, 2025
PureWeen
approved these changes
Jan 15, 2025
Member
PureWeen
left a comment
PureWeen
left a comment
There was a problem hiding this comment.
- Failing tests are unrelated. These changes are only on windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
When navigating back to the main page, the SelectedItem restores its old value instead of clearing it. As a result, when updating with the MapCurrentPage, it does not get updated properly.
Description of Issue Fix
The fix involves setting the SelectedItem property of the NavigationView to null in the disconnect handler to resolve the tab selection issue and setting IsSelected in the MapItemSource to true when page matches view.CurrentPage, addressing the background-related issue.
Also, the issue with the TitleColor of the TabbedPage not updating correctly has been resolved by triggering the PropertyChanged event for TitleColor within the IsSelected property.
Tested the behavior in the following platforms.
Issues Fixed
Fixes #24741
Output
24741-BeforeFix.mp4
24741-AfterFix.mp4