[iOS] Fix for Single item alignment issue in CollectionView HorizontalGrid Layout by Tamilarasan-Paranthaman · Pull Request #25370 · dotnet/maui

Tamilarasan-Paranthaman · 2024-10-18T09:56:13Z

Root Cause of the issue

The CollectionView seems to centre the item if only one exists. We had already adjusted the HorizontalAlignment for the VerticalGrid layout when a single element was in view. However, we missed making the same adjustment for the HorizontalGrid layout.

Description of Change

I have applied the same adjustment to the horizontal grid layout as was done for the vertical grid layout.

Issues Fixed

Fixes #25181

Tested the behaviour in the following platforms

Android
Windows
iOS
Mac

Screenshot

Before Issue Fix	After Issue Fix

dotnet-policy-service · 2024-10-18T09:56:33Z

Hey there @Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

jsuarezruiz · 2024-10-18T11:55:44Z

/azp run

azure-pipelines · 2024-10-18T11:56:03Z

Azure Pipelines successfully started running 3 pipeline(s).

Tamilarasan-Paranthaman · 2024-10-22T10:40:46Z

/rebase

PureWeen · 2024-10-24T16:38:41Z

/rebase

PureWeen

SingleItemAlignmentInCollectionViewHorizontalGridLayout is failing

Tamilarasan-Paranthaman · 2024-10-25T07:26:51Z

SingleItemAlignmentInCollectionViewHorizontalGridLayout is failing

@PureWeen, I added this test for this issue. There seems to be a slight difference between the previously committed image and the current one generated by the CI. However, the current image is correct, so I have committed it.

jsuarezruiz · 2024-10-25T10:14:42Z

/azp run

azure-pipelines · 2024-10-25T10:15:02Z

Azure Pipelines successfully started running 3 pipeline(s).

sheiksyedm · 2024-11-19T07:36:23Z

/rebase

rmarinho · 2024-12-11T15:37:30Z

/rebase

rmarinho · 2024-12-11T15:46:08Z

/azp run

azure-pipelines · 2024-12-11T15:46:34Z

Azure Pipelines successfully started running 3 pipeline(s).

rmarinho

The test is failing for CV1 seems the layout is expanding below the status bar and we cut that off for the test ? or do we need to regenerate images?

Original screenshot full screen

Tamilarasan-Paranthaman · 2024-12-12T07:21:33Z

The test is failing for CV1 seems the layout is expanding below the status bar and we cut that off for the test ? or do we need to regenerate images?

Original screenshot full screen

@rmarinho, Yes, it is expanding below the status bar, and it seems the CI did not account for that space. I have modified the test sample to address this by wrapping the CollectionView in a StackLayout, and it now passes both CV1 and CV2 on my end. Could you please review it and let me know if you have any concerns?

rmarinho · 2024-12-12T10:20:51Z

Nop wrapping a CollectionView on a StackLayout is not a good practice. Try use a Grid instead.

Tamilarasan-Paranthaman · 2024-12-12T11:00:32Z

Nop wrapping a CollectionView on a StackLayout is not a good practice. Try use a Grid instead.

@rmarinho, thank you for pointing this out! I have replaced the StackLayout with a Grid as suggested, and it worked as expected during my testing. Could you please check and let me know if you have any further concerns?

rmarinho · 2024-12-12T11:59:55Z

/azp run

azure-pipelines · 2024-12-12T12:01:11Z

Azure Pipelines successfully started running 3 pipeline(s).

dotnet-policy-service bot added the community ✨ Community Contribution label Oct 18, 2024

Tamilarasan-Paranthaman added platform/ios area-controls-collectionview CollectionView, CarouselView, IndicatorView labels Oct 18, 2024

Tamilarasan-Paranthaman changed the title ~~Fixed 25181.~~ [iOS] Fix for Single item alignment issue in CollectionView HorizontalGrid Layout. Oct 18, 2024

Tamilarasan-Paranthaman changed the title ~~[iOS] Fix for Single item alignment issue in CollectionView HorizontalGrid Layout.~~ [iOS] Fix for Single item alignment issue in CollectionView HorizontalGrid Layout Oct 18, 2024

Tamilarasan-Paranthaman marked this pull request as ready for review October 22, 2024 10:38

Tamilarasan-Paranthaman requested a review from a team as a code owner October 22, 2024 10:38

Tamilarasan-Paranthaman requested review from jfversluis and mattleibow October 22, 2024 10:38

github-actions bot force-pushed the fix-25181 branch 2 times, most recently from 5929285 to 3e94697 Compare October 22, 2024 21:56

github-actions bot force-pushed the fix-25181 branch from 3e94697 to fa3ff16 Compare October 24, 2024 16:39

PureWeen requested changes Oct 25, 2024

View reviewed changes

PureWeen added this to the .NET 9 Servicing milestone Oct 31, 2024

sheiksyedm added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 6, 2024

rmarinho previously approved these changes Dec 10, 2024

View reviewed changes

rmarinho requested a review from PureWeen December 10, 2024 10:07

rmarinho self-assigned this Dec 11, 2024

rmarinho modified the milestones: .NET 9 Servicing, .NET 9 SR3 Dec 11, 2024

dotnet deleted a comment from PureWeen Dec 11, 2024

dotnet deleted a comment from azure-pipelines bot Dec 11, 2024

dotnet deleted a comment from jsuarezruiz Dec 11, 2024

dotnet deleted a comment from PureWeen Dec 11, 2024

dotnet deleted a comment from azure-pipelines bot Dec 11, 2024

dotnet deleted a comment from jsuarezruiz Dec 11, 2024

Tamilarasan-Paranthaman added 5 commits December 11, 2024 15:41

Fixed 25181.

deaf345

Added snapshots.

9f16982

Added snapshots.

bca3b39

Fixed 25181.

de189b2

added snapshots for iOS.

fa15ad8

rmarinho dismissed their stale review via fa15ad8 December 11, 2024 15:45

rmarinho force-pushed the fix-25181 branch from 5342570 to fa15ad8 Compare December 11, 2024 15:45

rmarinho requested a review from jsuarezruiz as a code owner December 11, 2024 15:45

rmarinho requested changes Dec 11, 2024

View reviewed changes

test sample changes

855eb02

test sample changes

8894967

rmarinho approved these changes Dec 12, 2024

View reviewed changes

rmarinho merged commit 033e5b8 into dotnet:main Dec 12, 2024

samhouts added fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-net8.0-nightly This may be available in a nightly release! labels Dec 16, 2024

github-actions bot locked and limited conversation to collaborators Jan 17, 2025

Tamilarasan-Paranthaman deleted the fix-25181 branch June 16, 2025 11:02

Conversation

Tamilarasan-Paranthaman commented Oct 18, 2024

Root Cause of the issue

Description of Change

Issues Fixed

Tested the behaviour in the following platforms

Screenshot

Uh oh!

dotnet-policy-service bot commented Oct 18, 2024

Uh oh!

jsuarezruiz commented Oct 18, 2024

Uh oh!

azure-pipelines bot commented Oct 18, 2024

Uh oh!

Tamilarasan-Paranthaman commented Oct 22, 2024

Uh oh!

PureWeen commented Oct 24, 2024

Uh oh!

PureWeen left a comment

Choose a reason for hiding this comment

Uh oh!

Tamilarasan-Paranthaman commented Oct 25, 2024

Uh oh!

jsuarezruiz commented Oct 25, 2024

Uh oh!

azure-pipelines bot commented Oct 25, 2024

Uh oh!

sheiksyedm commented Nov 19, 2024

Uh oh!

rmarinho commented Dec 11, 2024

Uh oh!

rmarinho commented Dec 11, 2024

Uh oh!

azure-pipelines bot commented Dec 11, 2024

Uh oh!

rmarinho left a comment

Choose a reason for hiding this comment

Uh oh!

Tamilarasan-Paranthaman commented Dec 12, 2024

Uh oh!

rmarinho commented Dec 12, 2024

Uh oh!

Tamilarasan-Paranthaman commented Dec 12, 2024

Uh oh!

rmarinho commented Dec 12, 2024

Uh oh!

azure-pipelines bot commented Dec 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants