Skip to content

[Windows] Fix Shell.Flyout menu disappears when pressing Alt key#25479

Closed
Foda wants to merge 2 commits intomainfrom
foda/ShellMenu
Closed

[Windows] Fix Shell.Flyout menu disappears when pressing Alt key#25479
Foda wants to merge 2 commits intomainfrom
foda/ShellMenu

Conversation

@Foda
Copy link
Copy Markdown
Contributor

@Foda Foda commented Oct 23, 2024

Description of Change

Remove MeasureOverride and ArrangeOverride from `ShellFlyoutItemView. It's not clear why it exists, but it is the source of the issue.

The issue is caused by the logic in both of these functions not invoking base.ArrangeOverride and base.MeasureOverride.

Issues Fixed

Fixes #23214

Mike Corsaro added 2 commits October 22, 2024 15:39
Remove measure + arrange in ShellFlyoutItemView
@Foda Foda requested a review from PureWeen October 23, 2024 18:25
@Foda Foda requested a review from a team as a code owner October 23, 2024 18:25
@Foda Foda requested a review from tj-devel709 October 23, 2024 18:25
@jsuarezruiz jsuarezruiz added platform/windows area-controls-shell Shell Navigation, Routes, Tabs, Flyout t/bug Something isn't working labels Oct 24, 2024
@Foda Foda enabled auto-merge November 8, 2024 18:13
@Tamilarasan-Paranthaman
Copy link
Copy Markdown
Member

@Foda / @PureWeen, this also resolves the issue reported in 19496. I have attached a video for your reference.

Without this fix With this fix
before.mp4
after.mp4

@PureWeen
Copy link
Copy Markdown
Member

Closing this one in favor of #26966

@PureWeen PureWeen closed this Jan 16, 2025
auto-merge was automatically disabled January 16, 2025 21:55

Pull request was closed

@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-shell Shell Navigation, Routes, Tabs, Flyout platform/windows t/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flyout text dissappears after locking the screen

4 participants