Skip to content

[Windows] Fix for wrong secondary ToolbarItem size#25550

Merged
mattleibow merged 22 commits intodotnet:mainfrom
Tamilarasan-Paranthaman:fix-7156
Mar 11, 2025
Merged

[Windows] Fix for wrong secondary ToolbarItem size#25550
mattleibow merged 22 commits intodotnet:mainfrom
Tamilarasan-Paranthaman:fix-7156

Conversation

@Tamilarasan-Paranthaman
Copy link
Copy Markdown
Member

@Tamilarasan-Paranthaman Tamilarasan-Paranthaman commented Oct 28, 2024

Root Cause of the issue

We have a command bar without a defined style. It seems we need to obtain and apply the default style settings. As a result, style properties such as font size, item height, and popup height were not properly applied to the overflow presenter

Description of Change

I retrieved the default style for the command bar from the application's resources and applied it to the command bar.

Issues Fixed

Fixes #7156
Fixes #19166
Fixes #18258

Screenshot

Before After

@jsuarezruiz
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@Tamilarasan-Paranthaman Tamilarasan-Paranthaman marked this pull request as ready for review October 29, 2024 13:57
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman requested a review from a team as a code owner October 29, 2024 13:57
Copy link
Copy Markdown
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could include an UITest with a screenshot validation? In that way, we can validate that the ToolbarItem works, and the correct size.

@PureWeen PureWeen added this to the .NET 9 Servicing milestone Oct 31, 2024
@Tamilarasan-Paranthaman
Copy link
Copy Markdown
Member Author

Could include an UITest with a screenshot validation? In that way, we can validate that the ToolbarItem works, and the correct size.

@jsuarezruiz, I attempted to automate this, but unfortunately, it was unsuccessful. Currently, it seems that we are unable to add an AutomationID for the overflow icon in the toolbar to tap it. As a result, I tried tapping it using coordinates; however, this approach did not work either. I suspect that the coordinates might be incorrect or that the tap action is not functioning as expected on Windows. Could you please suggest if there are any other possible ways to automate this?

@sheiksyedm
Copy link
Copy Markdown
Contributor

/rebase

@jfversluis
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Copy Markdown
Contributor

jsuarezruiz commented Nov 4, 2024

Could include an UITest with a screenshot validation? In that way, we can validate that the ToolbarItem works, and the correct size.

@jsuarezruiz, I attempted to automate this, but unfortunately, it was unsuccessful. Currently, it seems that we are unable to add an AutomationID for the overflow icon in the toolbar to tap it. As a result, I tried tapping it using coordinates; however, this approach did not work either. I suspect that the coordinates might be incorrect or that the tap action is not functioning as expected on Windows. Could you please suggest if there are any other possible ways to automate this?

Added a new extension method in the Appium helper class: ToggleSecondaryToolbarItems
Also, included an UITest.

image

@jsuarezruiz jsuarezruiz self-requested a review November 4, 2024 12:38
@jsuarezruiz jsuarezruiz self-assigned this Nov 4, 2024
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 4, 2024
@jsuarezruiz
Copy link
Copy Markdown
Contributor

jsuarezruiz commented Nov 4, 2024

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@Tamilarasan-Paranthaman
Copy link
Copy Markdown
Member Author

Added a new extension method in the Appium helper class: ToggleSecondaryToolbarItems Also, included an UITest.

image

@jsuarezruiz, thank you for your effort in adding the ToggleSecondaryToolbarItems extension method and for including the UITest to automate this issue.

@Tamilarasan-Paranthaman
Copy link
Copy Markdown
Member Author

@jsuarezruiz / @PureWeen,

This change has caused a slight difference in the existing toolbar items on the Windows platform. It appears that the text has shifted slightly to the right, possibly due to the style we applied to the command bar. I have attached existing and current images. Could you please share your thoughts on this?

(Note: The first one is an old image, and the second one is a new image. The Title text has moved slightly to the right)

ChangeShellContentTitle-Old-Image

ChangeShellContentTitle-New-Image

@jsuarezruiz
Copy link
Copy Markdown
Contributor

/rebase

@Tamilarasan-Paranthaman
Copy link
Copy Markdown
Member Author

conflicts have been resolved.

@PureWeen, I have rebased it and resolved the conflicts. Could you please review and let me know if you have any concerns?

@PureWeen PureWeen moved this from Changes Requested to Ready To Review in MAUI SDK Ongoing Mar 2, 2025
@PureWeen PureWeen dismissed their stale review March 2, 2025 22:07

Changes Made

@jsuarezruiz
Copy link
Copy Markdown
Contributor

/rebase

@jsuarezruiz
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen modified the milestones: .NET 9 SR5, .NET 9 SR6 Mar 7, 2025
@github-project-automation github-project-automation bot moved this from Ready To Review to Approved in MAUI SDK Ongoing Mar 11, 2025
@mattleibow mattleibow merged commit ae2c74b into dotnet:main Mar 11, 2025
123 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Mar 11, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2025
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman deleted the fix-7156 branch June 16, 2025 11:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-toolbar ToolBar community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/windows

Projects

Status: Done

8 participants