[Windows] Fix for wrong secondary ToolbarItem size#25550
[Windows] Fix for wrong secondary ToolbarItem size#25550mattleibow merged 22 commits intodotnet:mainfrom
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
left a comment
There was a problem hiding this comment.
Could include an UITest with a screenshot validation? In that way, we can validate that the ToolbarItem works, and the correct size.
@jsuarezruiz, I attempted to automate this, but unfortunately, it was unsuccessful. Currently, it seems that we are unable to add an AutomationID for the overflow icon in the toolbar to tap it. As a result, I tried tapping it using coordinates; however, this approach did not work either. I suspect that the coordinates might be incorrect or that the tap action is not functioning as expected on Windows. Could you please suggest if there are any other possible ways to automate this? |
|
/rebase |
5bf739e to
ca8f559
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Added a new extension method in the Appium helper class: ToggleSecondaryToolbarItems |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
@jsuarezruiz, thank you for your effort in adding the ToggleSecondaryToolbarItems extension method and for including the UITest to automate this issue. |
|
This change has caused a slight difference in the existing toolbar items on the Windows platform. It appears that the text has shifted slightly to the right, possibly due to the style we applied to the command bar. I have attached existing and current images. Could you please share your thoughts on this? (Note: The first one is an old image, and the second one is a new image. The Title text has moved slightly to the right) |
|
/rebase |
70ebb4c to
001b469
Compare
22c6ab6 to
5312bb5
Compare
@PureWeen, I have rebased it and resolved the conflicts. Could you please review and let me know if you have any concerns? |
6a095b7 to
31ca63b
Compare
31ca63b to
1efa6ca
Compare
|
/rebase |
1efa6ca to
76cc732
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
76cc732 to
e64445d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |




Root Cause of the issue
We have a command bar without a defined style. It seems we need to obtain and apply the default style settings. As a result, style properties such as font size, item height, and popup height were not properly applied to the overflow presenter
Description of Change
I retrieved the default style for the command bar from the application's resources and applied it to the command bar.
Issues Fixed
Fixes #7156
Fixes #19166
Fixes #18258
Screenshot