Fixed CollectionView SelectedItem binding issue on initial loading#25555
Merged
rmarinho merged 32 commits intodotnet:mainfrom Nov 26, 2024
Merged
Fixed CollectionView SelectedItem binding issue on initial loading#25555rmarinho merged 32 commits intodotnet:mainfrom
rmarinho merged 32 commits intodotnet:mainfrom
Conversation
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
suggested changes
Oct 31, 2024
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
requested changes
Nov 5, 2024
Member
PureWeen
left a comment
There was a problem hiding this comment.
CollectionViewPreSelectionShouldUpdate
Failing
Contributor
Author
|
Hi @PureWeen , The CollectionViewPreSelectionShouldUpdate failed due to a missing snapshot on the Windows platform. We have now included the snapshot. Please review and let us know if there are any concerns. |
Member
|
/rebase |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/rebase |
rmarinho
approved these changes
Nov 26, 2024
This was referenced Nov 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Details
Root Cause
ListViewBase.IsSynchronizedWithCurrentItemproperty setting. Additionally, the visual state is applied before the item view control is created.ItemsSource.Fix Details
SelectedItemwhile updating the native view property. Additionally, theItemContentControl's visual state is now applied after it is created.Reference:
iOS - ios - How to select some items in the UICollectionView after it first load? - Stack Overflow
Issues Fixed
Fixes #25551
Fixes #23299
Output Screenshot