Skip to content

Better exception for using viewCell with collection View#25681

Merged
mattleibow merged 1 commit intodotnet:mainfrom
kubaflo:fix-24379
Nov 13, 2024
Merged

Better exception for using viewCell with collection View#25681
mattleibow merged 1 commit intodotnet:mainfrom
kubaflo:fix-24379

Conversation

@kubaflo
Copy link
Copy Markdown
Contributor

@kubaflo kubaflo commented Nov 5, 2024

Description of Change

The exception thrown when using ViewCell within a DataTemplate in CollectionView is currently uninformative and inconsistent across platforms. This inconsistency can confuse developers who may not realize that ViewCell is incompatible with CollectionView and may frequently encounter this issue.

Issues Fixed

Fixes #24379

Before After
Android
iOS

@jsuarezruiz jsuarezruiz self-requested a review November 8, 2024 12:36
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 8, 2024
@jsuarezruiz
Copy link
Copy Markdown
Contributor

/rebase

@jsuarezruiz
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@mattleibow mattleibow added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label Nov 13, 2024
@mattleibow mattleibow merged commit b9562d0 into dotnet:main Nov 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CollectionView throws NRE when ItemTemplate uses a ViewCell as parent

4 participants