-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[iOS] Fix for Editor scaling creating new lines on older iOS versions #25691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8329e16
Fixed 25581.
Tamilarasan-Paranthaman e84d085
Added TestCase.
Tamilarasan-Paranthaman 933be07
Fixed 25581.
Tamilarasan-Paranthaman a31e97e
Added TestCase.
Tamilarasan-Paranthaman 62aafd8
Added snapshot for WinUI.
Tamilarasan-Paranthaman 7aa103d
Merge branch 'fix-25581' of https://github.com/Tamilarasan-Paranthama…
Tamilarasan-Paranthaman 9a57450
Test failures have been fixed
Tamilarasan-Paranthaman 53994ac
Changed to appropriate version
Tamilarasan-Paranthaman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file added
BIN
+22.9 KB
.../tests/TestCases.Android.Tests/snapshots/android/VerifyDynamicEditorScaling.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
20 changes: 20 additions & 0 deletions
20
src/Controls/tests/TestCases.HostApp/Issues/Issue25581.xaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| <?xml version="1.0" encoding="utf-8" ?> | ||
| <ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui" | ||
| xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml" | ||
| x:Class="Maui.Controls.Sample.Issues.Issue25581" | ||
| xmlns:ns="clr-namespace:Maui.Controls.Sample.Issues"> | ||
|
|
||
| <VerticalStackLayout> | ||
| <Button Text="Change Scale" | ||
| AutomationId="Button" | ||
| Clicked="Button_Clicked"/> | ||
| <Editor | ||
| x:Name="editor" | ||
| Text="1234567890" | ||
| Background="Red" | ||
| FontSize="32" | ||
| HorizontalOptions="Center" | ||
| HorizontalTextAlignment="Center"/> | ||
|
|
||
| </VerticalStackLayout> | ||
| </ContentPage> |
15 changes: 15 additions & 0 deletions
15
src/Controls/tests/TestCases.HostApp/Issues/Issue25581.xaml.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| namespace Maui.Controls.Sample.Issues; | ||
|
|
||
| [Issue(IssueTracker.Github, 25581, "Editor Scaling creating new lines on older iOS versions", PlatformAffected.iOS)] | ||
| public partial class Issue25581 : ContentPage | ||
| { | ||
| public Issue25581() | ||
| { | ||
| InitializeComponent(); | ||
| } | ||
|
|
||
| private void Button_Clicked(object sender, EventArgs e) | ||
| { | ||
| editor.Scale = 0.5; | ||
| } | ||
| } |
27 changes: 27 additions & 0 deletions
27
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25581.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| #if !MACCATALYST | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues | ||
| { | ||
| public class Issue25581 : _IssuesUITest | ||
| { | ||
| public override string Issue => "Editor Scaling creating new lines on older iOS versions"; | ||
|
|
||
| public Issue25581(TestDevice device) | ||
| : base(device) | ||
| { } | ||
|
|
||
| [Test] | ||
| [Category(UITestCategories.Editor)] | ||
| public void VerifyDynamicEditorScaling() | ||
| { | ||
| App.WaitForElement("Button"); | ||
| App.Tap("Button"); | ||
|
|
||
| VerifyScreenshot(); | ||
| } | ||
| } | ||
| } | ||
| #endif |
Binary file added
BIN
+7.04 KB
...ls/tests/TestCases.WinUI.Tests/snapshots/windows/VerifyDynamicEditorScaling.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+21.7 KB
...Controls/tests/TestCases.iOS.Tests/snapshots/ios/VerifyDynamicEditorScaling.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.