[Testing] Enabling ported UITests from Xamarin.UITests to Appium#25711
Conversation
Contributor
|
Hey there @anandhan-rajagopal! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jsuarezruiz
reviewed
Nov 6, 2024
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Bugzilla/Bugzilla43161.cs
Show resolved
Hide resolved
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/XFIssue/Issue12246.cs
Show resolved
Hide resolved
| public void VerifyNestedStacklayoutTapsBubble() | ||
| { | ||
| App.WaitForElement(InnerLayout); | ||
| App.Tap(InnerLayout); |
Contributor
There was a problem hiding this comment.
Methods like WaitForElement or Tap for example, search first by AutomationId and if don't find the element, make a query using XPath searching by content (text etc). In principle, it shouldn't be necessary to modify the test example by adding AutomationIds for it to work.
On the other hand, using AutomationId is more efficient than queries, so it's a good practice.
Author
|
@dotnet-policy-service agree |
ghost
marked this pull request as ready for review
Contributor
|
/rebase |
added 10 commits
November 8, 2024 11:44
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
approved these changes
Nov 8, 2024
mattleibow
approved these changes
Nov 11, 2024
Member
|
ghost
added
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR focuses on re-enabling and updating following tests from the Xamarin.UITest framework to be compatible with Appium. The tests, previously commented out, are reviewed, and modified to ensure they are functional with the Appium framework.
TestCases