Conversation
mono is no longer found on machines
mattleibow
commented
Nov 12, 2024
Comment on lines
+361
to
-365
| Zip(assetsDir, $"{assetsDir}.zip"); | ||
| foreach (var nupkg in GetFiles($"{assetsDir}/**/*.nupkg")) | ||
| DeleteFile(nupkg); | ||
| Zip(assetsDir, $"{assetsDir}.zip"); |
Member
Author
There was a problem hiding this comment.
I have no idea how this ever worked... We delete and then zip? Seems to have always been like that since my first commit??? #2415
Member
There was a problem hiding this comment.
were we actually shipping anything extra?
rmarinho
requested changes
Nov 12, 2024
Member
rmarinho
left a comment
rmarinho
left a comment
There was a problem hiding this comment.
D:/a/1/s/eng/devices/windows.cake(99,57): error CS0104: 'HashAlgorithmName' is an ambiguous reference between 'NuGet.Common.HashAlgorithmName' and 'System.Security.Cryptography.HashAlgorithmName'
mattleibow
added
the
area-infrastructure
rmarinho
reviewed
Nov 13, 2024
Member
rmarinho
left a comment
rmarinho
left a comment
There was a problem hiding this comment.
What happens if we remove this ? will it fail to build/sign ?
Member
Author
|
This is used to upload symbols to symweb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
mono is no longer found on machines, so we need to use the NuGet APIs directly.