[iOS] Fix for CollectionView with horizontal grid layout has extra space on right end#25825
Merged
rmarinho merged 4 commits intodotnet:mainfrom Dec 5, 2024
Merged
Conversation
Contributor
|
Hey there @Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Nov 13, 2024
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25433.cs
Outdated
Show resolved
Hide resolved
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
4 tasks
rmarinho
approved these changes
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause of the issue
HorizontalItemSpacingwas being applied from theGetInsetForSectionmethod, even though it was not a grouped collectionDescription of Change
Note
HorizontalOptionsset to center, as it seems the collection view occupies the entire width in CV2. For now, I have used CollectionView1 in the test sample since I have fixed the issue in CollectionView1.maui/src/Controls/tests/TestCases.HostApp/Issues/Issue25433.xaml
Line 8 in d0d9a53
Issues Fixed
Fixes #25433
Tested the behaviour in the following platforms
Screenshot
1. Without Grouping:
2. With Grouping