Fixed CarouselView Loop="False" rendering items incorrectly - test fix#25924
Merged
rmarinho merged 3 commits intodotnet:mainfrom Nov 19, 2024
Merged
Fixed CarouselView Loop="False" rendering items incorrectly - test fix#25924rmarinho merged 3 commits intodotnet:mainfrom
rmarinho merged 3 commits intodotnet:mainfrom
Conversation
Contributor
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
kubaflo
changed the title
Contributor
|
/azp run |
jsuarezruiz
added
the
area-controls-collectionview
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Nov 19, 2024
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/CarouselViewShouldRenderCorrectly.png
Show resolved
Hide resolved
rmarinho
approved these changes
Nov 19, 2024
jsuarezruiz
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item spacing was not working on iOS at the time of adding snapshot. The CarouselView2 for iOS fixed it, so I've updated the iOS screenshot to fix UI test
Issues Fixed
Fixes #25545
@rmarinho