Border.Shadow hide the collectionView Header/footer -UITest by kubaflo · Pull Request #25960 · dotnet/maui

kubaflo · 2024-11-19T19:45:54Z

Description of Change

Whenever a view, wrapped inside a wrapper view, has been a direct child of a header or footer element, it either didn't show at all or rendered incorrectly.

Issues Fixed

Fixes #19338

Before	After

rmarinho · 2024-11-20T03:12:13Z

/rebase

rmarinho · 2024-11-20T03:14:01Z

/azp run

azure-pipelines · 2024-11-20T03:14:23Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2024-11-20T07:18:41Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19338.cs

+		public void Issue935TestsMultipleOnTappedViewCell()
+		{
+			App.WaitForElement("HeaderLabel");
+			VerifyScreenshot();


Snapshots available in the latest build:

Could you commit the images?

I had to add margin to the collection, so I need to re-upload screenshots

rmarinho · 2024-11-20T23:25:58Z

/rebase

rmarinho · 2024-11-20T23:26:44Z

/azp run

azure-pipelines · 2024-11-20T23:27:04Z

Azure Pipelines successfully started running 3 pipeline(s).

rmarinho · 2024-11-20T23:27:09Z

/azp run maui-pr

azure-pipelines · 2024-11-20T23:27:15Z

No pipelines are associated with this pull request.

jsuarezruiz

The test HeaderAndFooterShouldBeVisible is failing on all the platforms. After the margin change, need to update the snapshot in all the platforms. Images available in the latest build.

jsuarezruiz · 2024-11-22T11:01:13Z

/azp run

azure-pipelines · 2024-11-22T11:01:36Z

Azure Pipelines successfully started running 3 pipeline(s).

rmarinho · 2024-11-27T12:09:36Z

/azp run

azure-pipelines · 2024-11-27T12:09:57Z

Azure Pipelines successfully started running 3 pipeline(s).

rmarinho

Does this work fine with CollectionView2 ?

kubaflo · 2024-11-27T12:18:34Z

Hi, @rmarinho I was testing it on the sandbox project on the latest main which I think uses cv2, right?

rmarinho · 2024-11-27T12:21:25Z

It depends the time you tested.. but this fix is for CV1

kubaflo · 2024-11-27T13:06:50Z

I tried on today's main and this is the result for cv1:

And this one is for the cv2

So it appears the problem is only with the cv1

@rmarinho should I close this PR then?

PureWeen · 2024-12-07T15:31:25Z

/azp run

azure-pipelines · 2024-12-07T15:31:45Z

Azure Pipelines successfully started running 3 pipeline(s).

rmarinho

Can we rebase and see how it works with the new container?

kubaflo · 2024-12-11T10:32:31Z

@rmarinho yess it works with the new generalWrapperView! But, maybe let's keep the UI test?

rmarinho · 2024-12-11T14:01:36Z

/azp run

azure-pipelines · 2024-12-11T14:01:59Z

Azure Pipelines successfully started running 3 pipeline(s).

rmarinho

Do we need new images ?

CV1

CV2

rmarinho · 2024-12-11T16:33:12Z

Diff

kubaflo · 2024-12-11T16:56:00Z

@rmarinho yea I modified the test a bit and was waiting to re-upload snapshots. It should be green now :)

rmarinho · 2024-12-11T16:57:28Z

/azp run

azure-pipelines · 2024-12-11T16:57:50Z

Azure Pipelines successfully started running 3 pipeline(s).

kubaflo · 2024-12-12T17:06:00Z

@rmarinho I think the tests passed for this issue

kubaflo requested a review from a team as a code owner November 19, 2024 19:45

kubaflo requested review from Eilon and tj-devel709 November 19, 2024 19:45

dotnet-policy-service bot added the community ✨ Community Contribution label Nov 19, 2024

github-actions bot force-pushed the fix-19338 branch from 1dbc405 to c6982c9 Compare November 20, 2024 03:12

jsuarezruiz suggested changes Nov 20, 2024

View reviewed changes

kubaflo force-pushed the fix-19338 branch from c6982c9 to aaab2d4 Compare November 20, 2024 10:31

github-actions bot force-pushed the fix-19338 branch from aaab2d4 to 0b8f1cf Compare November 20, 2024 23:26

jsuarezruiz added area-controls-collectionview CollectionView, CarouselView, IndicatorView area-controls-border Border labels Nov 21, 2024

jsuarezruiz suggested changes Nov 21, 2024

View reviewed changes

kubaflo force-pushed the fix-19338 branch from 0b8f1cf to 76092e0 Compare November 21, 2024 10:30

kubaflo requested a review from jsuarezruiz November 21, 2024 10:31

kubaflo force-pushed the fix-19338 branch from 76092e0 to 58b9534 Compare November 25, 2024 00:15

rmarinho reviewed Nov 27, 2024

View reviewed changes

PureWeen modified the milestones: .NET 9 SR2, .NET 9 SR3 Dec 6, 2024

kubaflo force-pushed the fix-19338 branch from cff7d6c to 66c5ae4 Compare December 7, 2024 13:58

rmarinho requested review from PureWeen and rmarinho December 9, 2024 11:54

rmarinho requested changes Dec 11, 2024

View reviewed changes

kubaflo force-pushed the fix-19338 branch from 66c5ae4 to fa79d9e Compare December 11, 2024 10:29

kubaflo requested a review from jfversluis as a code owner December 11, 2024 10:29

kubaflo changed the title ~~Border.Shadow hide the collectionView Header/footer - fix~~ Border.Shadow hide the collectionView Header/footer -UITest Dec 11, 2024

kubaflo force-pushed the fix-19338 branch from fa79d9e to b7846bd Compare December 11, 2024 12:33

Border.Shadow hide the collectionView1 Header/footer - fix

1f70c09

kubaflo force-pushed the fix-19338 branch from b7846bd to 1f70c09 Compare December 11, 2024 12:41

rmarinho approved these changes Dec 11, 2024

View reviewed changes

rmarinho requested changes Dec 11, 2024

View reviewed changes

Updated snapshots

e16b50f

rmarinho approved these changes Dec 12, 2024

View reviewed changes

rmarinho merged commit 612b4b1 into dotnet:main Dec 12, 2024

samhouts added fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-net8.0-nightly This may be available in a nightly release! labels Dec 16, 2024

github-actions bot locked and limited conversation to collaborators Jan 16, 2025

Conversation

kubaflo commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Issues Fixed

Uh oh!

rmarinho commented Nov 20, 2024

Uh oh!

rmarinho commented Nov 20, 2024

Uh oh!

azure-pipelines bot commented Nov 20, 2024

Uh oh!

jsuarezruiz Nov 20, 2024

Choose a reason for hiding this comment

Uh oh!

kubaflo Nov 20, 2024

Choose a reason for hiding this comment

Uh oh!

rmarinho commented Nov 20, 2024

Uh oh!

rmarinho commented Nov 20, 2024

Uh oh!

azure-pipelines bot commented Nov 20, 2024

Uh oh!

rmarinho commented Nov 20, 2024

Uh oh!

azure-pipelines bot commented Nov 20, 2024

Uh oh!

jsuarezruiz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Nov 22, 2024

Uh oh!

azure-pipelines bot commented Nov 22, 2024

Uh oh!

rmarinho commented Nov 27, 2024

Uh oh!

azure-pipelines bot commented Nov 27, 2024

Uh oh!

rmarinho left a comment

Choose a reason for hiding this comment

Uh oh!

kubaflo commented Nov 27, 2024

Uh oh!

rmarinho commented Nov 27, 2024

Uh oh!

kubaflo commented Nov 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PureWeen commented Dec 7, 2024

Uh oh!

azure-pipelines bot commented Dec 7, 2024

Uh oh!

rmarinho left a comment

Choose a reason for hiding this comment

Uh oh!

kubaflo commented Dec 11, 2024

Uh oh!

rmarinho commented Dec 11, 2024

Uh oh!

azure-pipelines bot commented Dec 11, 2024

Uh oh!

rmarinho left a comment

Choose a reason for hiding this comment

Uh oh!

rmarinho commented Dec 11, 2024

Uh oh!

kubaflo commented Dec 11, 2024

Uh oh!

rmarinho commented Dec 11, 2024

Uh oh!

azure-pipelines bot commented Dec 11, 2024

Uh oh!

kubaflo commented Dec 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

kubaflo commented Nov 19, 2024 •

edited

Loading

jsuarezruiz left a comment •

edited

Loading

kubaflo commented Nov 27, 2024 •

edited

Loading