[HybridWebView] Add support for async .NET methods#25967
Merged
mattleibow merged 4 commits intomainfrom Jan 23, 2025
Merged
Conversation
mattleibow
requested review from
Eilon,
jsuarezruiz,
rmarinho and
tj-devel709
and removed request for
jsuarezruiz and
rmarinho
mattleibow
commented
Nov 19, 2024
Eilon
reviewed
Nov 19, 2024
Eilon
reviewed
Nov 19, 2024
Eilon
reviewed
Nov 19, 2024
jfversluis
added
the
area-architecture
|
Any ETA when with this be available in .NET MAUI? Either in preview or other? |
mattleibow
added
area-controls-hybridwebview
mattleibow
force-pushed
the
dev/hybridwebview-async-support
branch
2 times, most recently
from
714b204 to
68028a8
Compare
mattleibow
changed the title
mattleibow
force-pushed
the
dev/hybridwebview-async-support
branch
from
68028a8 to
a5ae2c2
Compare
mattleibow
force-pushed
the
dev/hybridwebview-async-support
branch
from
a5ae2c2 to
56070a8
Compare
tj-devel709
approved these changes
Jan 21, 2025
Member
Author
|
Test failures unrelated to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR makes the call from JS into .NET be able to support async methods (return
TaskorTask<T>)This PR has a fair bit of things moving around because of the async and the fact that I wanted to make the code flow the same on all the platforms. The code was getting a bit nested, so I broke things out into methods.
Issues Fixed
Fixes #25968