Skip to content

[Windows] Hide/show titlebar on modal pages#26071

Merged
jfversluis merged 2 commits intomainfrom
foda/TitlebarModal
Nov 26, 2024
Merged

[Windows] Hide/show titlebar on modal pages#26071
jfversluis merged 2 commits intomainfrom
foda/TitlebarModal

Conversation

@Foda
Copy link
Copy Markdown
Contributor

@Foda Foda commented Nov 22, 2024

Description of Change

Toggle the titlebar visibility when modal pages are pushed/popped.

Issues Fixed

Fixes #25964

@Foda Foda requested review from PureWeen and mattleibow November 22, 2024 20:10
@Foda Foda requested a review from a team as a code owner November 22, 2024 20:10
PureWeen
PureWeen previously approved these changes Nov 22, 2024
@PureWeen
Copy link
Copy Markdown
Member

/backport to release/9.0.1xx

@github-actions
Copy link
Copy Markdown
Contributor

Started backporting to release/9.0.1xx: https://github.com/dotnet/maui/actions/runs/11981567160

@mattleibow
Copy link
Copy Markdown
Member

Can we get tests for this one?

@PureWeen
Copy link
Copy Markdown
Member

Can we get tests for this one?

we could probably validate the raw control.
The screen shot tests don't work because we cut off the titlebar so we can use screen comparison tests :-/

We're going to add a manual test as well here for validation

@jsuarezruiz
Copy link
Copy Markdown
Contributor

Can we get tests for this one?

Can we get tests for this one?

we could probably validate the raw control. The screen shot tests don't work because we cut off the titlebar so we can use screen comparison tests :-/

We're going to add a manual test as well here for validation

We could maybe manage the cutting logic, to avoid it when necessary. But, yeah, with a Device Test should be enough.


if (windowManager.RootView is WindowRootView wrv)
// Hide titlebar on previous page
var previousContext = previousPage.FindMauiContext();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure -- lemme add that to the existing modal push/pop Windows tests

@jfversluis jfversluis merged commit 2c08a0d into main Nov 26, 2024
@jfversluis jfversluis deleted the foda/TitlebarModal branch November 26, 2024 10:21
@samhouts samhouts added fixed-in-9.0.21 fixed-in-net8.0-nightly This may be available in a nightly release! labels Dec 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[WinUI] App TitleBar overlapping on .NET9 when using Modals

6 participants