Skip to content

[Windows] TabbedPage: Refresh layout when NavigationView size changes #26217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BagavathiPerumal wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[Windows] TabbedPage: Refresh layout when NavigationView size changes #26217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c1eda55
fix-26103-Added measure invalidation before arranging NavigationView …
BagavathiPerumal Nov 28, 2024
8ad5326
fix-26103-Removed the Arrange() call from the SizeChanged method.
BagavathiPerumal Jan 10, 2025
d049ffe
fix-26103-Removed unwanted spacing.
BagavathiPerumal Jan 10, 2025
335aa19
fix-26103-Prevents frame dimensions from remaining at -1 when only us…
BagavathiPerumal Oct 29, 2025
e4a80c4
fix-26103-Resaved the test image.
BagavathiPerumal Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Controls/src/Core/TabbedPage/TabbedPage.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,12 @@ void OnApplyTemplateFinished(object? sender, EventArgs e)
void OnNavigationViewSizeChanged(object sender, SizeChangedEventArgs e)
{
if (_navigationView != null)
{
// Ensure TabbedPage layout responds to NavigationView size changes
this.InvalidateMeasure();
Copy link
Copy Markdown
Member

@PureWeen PureWeen Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove the call to this.Arrange and leave this.InvalidateMeasure does this all still work?

The call to arrange inside the SizeChanged method here doesn't seem correct.

Also, can you add a test?

Copy link
Copy Markdown
Contributor Author

@BagavathiPerumal BagavathiPerumal Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PureWeen, I have implemented the suggested changes, tested the fix across all basic scenarios, and also ran UI tests.

Testcase: The test case cannot be created for this scenario as resizing the window to a minimized state is not feasible during testing. Therefore, we have not added a test case for this scenario. Could you suggest alternative ways to address this, since resizing the window to a minimized state isn't possible during testing.

Copy link
Copy Markdown
Contributor

@jsuarezruiz jsuarezruiz Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to resize the Window or minimize and maximize it?

Copy link
Copy Markdown
Contributor Author

@BagavathiPerumal BagavathiPerumal Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsuarezruiz, The issue occurs only when resizing the window. Could you please share your suggestions on how to resolve it.

Copy link
Copy Markdown
Contributor Author

@BagavathiPerumal BagavathiPerumal Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PureWeen, The Arrange() call in the NavigationView SizeChanged method is necessary to prevent test failures. Without this change, the ChangingToNewMauiContextDoesntCrash test consistently fails with a timeout exception.

// Complete layout to fix frame dimensions
this.Arrange(_navigationView);
}
}

void SetupNavigationView()
Expand Down
Binary file modified ...inUI.Tests/snapshots/windows/DefaultSelectedTabTextColorShouldApplyProperly.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...nUI.Tests/snapshots/windows/DynamicFontImageSourceColorShouldApplyOnTabIcon.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ases.WinUI.Tests/snapshots/windows/FontImageSourceColorShouldApplyOnTabIcon.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/Issue1323Test.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...estCases.WinUI.Tests/snapshots/windows/TabBarIconsShouldAutoscaleTabbedPage.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...s/TestCases.WinUI.Tests/snapshots/windows/VerifyTabbedPageMenuItemTextColor.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading