Skip to content

[Android] Fix for Softkeyboard Return key of an Entry control shows Done when the property ReturnType is set to Next#26501

Merged
jfversluis merged 1 commit intodotnet:mainfrom
Tamilarasan-Paranthaman:fix-23086
Dec 18, 2024
Merged

[Android] Fix for Softkeyboard Return key of an Entry control shows Done when the property ReturnType is set to Next#26501
jfversluis merged 1 commit intodotnet:mainfrom
Tamilarasan-Paranthaman:fix-23086

Conversation

@Tamilarasan-Paranthaman
Copy link
Copy Markdown
Member

Root Cause of the issue

  • Setting the ImeOptions of the EditText before the view is attached or added to the view hierarchy may not be effective, as it will not reflect on the keyboard

Description of Change

  • I called the UpdateReturnType method from OnViewAttachedToWindow and removed the SetInputType method from UpdateReturnType, as it resets the default behavior of the KeyListener and SelectionLength.

  • This fix ensures the proper functioning of the initial loading of returnType, dynamic changes to returnType, custom KeyListener behavior, and SelectionLength.

Regressed PR

Issues Fixed

Fixes #23086

Tested the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Screenshot

Before Issue Fix After Issue Fix
ReturnTypeNotworks.mov
ReturnTypeWorks.mov

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Dec 10, 2024
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Hey there @Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jfversluis
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis jfversluis added this to the .NET 9 SR3 milestone Dec 18, 2024
@jfversluis jfversluis merged commit bdb3b3c into dotnet:main Dec 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman deleted the fix-23086 branch June 16, 2025 11:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-entry Entry community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Softkeyboard Return key of an Entry control shows Done when the property ReturnType is set to Next

2 participants