Skip to content

Invert SourceRect width/height on orientation change for ActionSheet#26561

Merged
jfversluis merged 2 commits intodotnet:mainfrom
eth-ellis:bugfix/26560-action-sheet-orientation-change
Dec 13, 2024
Merged

Invert SourceRect width/height on orientation change for ActionSheet#26561
jfversluis merged 2 commits intodotnet:mainfrom
eth-ellis:bugfix/26560-action-sheet-orientation-change

Conversation

@eth-ellis
Copy link
Copy Markdown
Contributor

@eth-ellis eth-ellis commented Dec 12, 2024

Description of Change

Invert SourceRect width/height on orientation change for ActionSheet to ensure it says centred.

Issues Fixed

Fixes #26560

Before After
Simulator Screen Recording - iPad Pro 11-inch (M4) - 2024-12-12 at 18 14 02 Simulator Screen Recording - iPad Pro 11-inch (M4) - 2024-12-12 at 18 05 41

@eth-ellis eth-ellis requested a review from a team as a code owner December 12, 2024 07:13
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Dec 12, 2024
@jfversluis
Copy link
Copy Markdown
Member

jfversluis commented Dec 12, 2024

/azp run

@azure-pipelines

This comment was marked as outdated.

@jfversluis
Copy link
Copy Markdown
Member

Thinking of how we could add a test for this, I guess a snapshot test would be easiest

@eth-ellis
Copy link
Copy Markdown
Contributor Author

@jfversluis Is there documentation on where/how to add a snapshot test for this?

@jfversluis
Copy link
Copy Markdown
Member

Please don't merge main into this unless you really have to. That will reset the build status and I will need to trigger it again and a whole new run will begin. Thanks!

As for the testing docs, this should be helpful: https://github.com/dotnet/maui/blob/main/docs/design/UITesting.md#screenshots

@eth-ellis
Copy link
Copy Markdown
Contributor Author

@jfversluis Yep, realised that as soon as I did it. Need to resist the urge to always be 100% up to date with main 😆

Cheers, that doco outlines the process very clearly!

Is there a way to run this test on an iPad though as this is an iPad specific issue?
From what I can tell, all of the snapshots appear to be from an iPhone.

@jfversluis
Copy link
Copy Markdown
Member

Ah yeah that's a good call. They all run on iPhones only right now. OK I'll have a closer look, don't worry about the test for now.

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis
Copy link
Copy Markdown
Member

Thanks for reporting and fixing the bug yourself! Much appreciated!

@jfversluis jfversluis merged commit 38b3c64 into dotnet:main Dec 13, 2024
@jfversluis jfversluis added this to the .NET 9 SR3 milestone Dec 13, 2024
@samhouts samhouts added fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-net8.0-nightly This may be available in a nightly release! labels Dec 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-dialogalert DisplayAlert, dialog community ✨ Community Contribution fixed-in-net8.0-nightly This may be available in a nightly release! fixed-in-net9.0-nightly This may be available in a nightly release! platform/ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iPad - ActionSheet does not stay in the centre of the screen on orientation change

3 participants