Invert SourceRect width/height on orientation change for ActionSheet#26561
Conversation
|
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
|
Thinking of how we could add a test for this, I guess a snapshot test would be easiest |
|
@jfversluis Is there documentation on where/how to add a snapshot test for this? |
|
Please don't merge main into this unless you really have to. That will reset the build status and I will need to trigger it again and a whole new run will begin. Thanks! As for the testing docs, this should be helpful: https://github.com/dotnet/maui/blob/main/docs/design/UITesting.md#screenshots |
|
@jfversluis Yep, realised that as soon as I did it. Need to resist the urge to always be 100% up to date with main 😆 Cheers, that doco outlines the process very clearly! Is there a way to run this test on an iPad though as this is an iPad specific issue? |
|
Ah yeah that's a good call. They all run on iPhones only right now. OK I'll have a closer look, don't worry about the test for now. |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Thanks for reporting and fixing the bug yourself! Much appreciated! |
Description of Change
Invert SourceRect width/height on orientation change for ActionSheet to ensure it says centred.
Issues Fixed
Fixes #26560