The fix for child FlexLayout content appearing no longer works starting from version 8.0.61#26665
Conversation
|
Hey there @Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/Controls/src/Core/Layout/FlexLayout.cs:588
- Ensure that the new behavior introduced by the inMeasureMode parameter is covered by tests.
_root.Layout(InMeasureMode);
| } | ||
|
|
||
| public delegate void SelfSizingDelegate(Item item, ref float width, ref float height); | ||
| public delegate void SelfSizingDelegate(Item item, ref float width, ref float height, bool inMeasureMode); |
There was a problem hiding this comment.
The change in the delegate signature is potentially a breaking change. Please ensure that this change is documented and communicated appropriately.
This comment was generated based on a coding guideline created by a repository admin.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
StephaneDelcroix
left a comment
There was a problem hiding this comment.
I don't see the relation between the fix and the title (FlexLayout vs BindableLayout). could you please fix the PR subject ?
@StephaneDelcroix, I have updated the PR title to reflect the fixed context. Could you please review it now? |
Root Cause of the issue
Description of Change
Regressed PR
Issues Fixed
Fixes #23491
Tested the behaviour in the following platforms
Screenshot
Windows
Android
iOS
Mac