Skip to content

[X] Avoid unnecessary steps #26671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 1 commit into from
Jan 14, 2025
Merged

[X] Avoid unnecessary steps #26671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions src/Controls/src/Build.Tasks/CompiledValueProviders/PassthroughValueProvider.cs
View file
Open in desktop

This file was deleted.

10 changes: 1 addition & 9 deletions src/Controls/src/Core/Interactivity/BindingCondition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@
namespace Microsoft.Maui.Controls
{
/// <include file="../../../docs/Microsoft.Maui.Controls/BindingCondition.xml" path="Type[@FullName='Microsoft.Maui.Controls.BindingCondition']/Docs/*" />
[ProvideCompiled("Microsoft.Maui.Controls.XamlC.PassthroughValueProvider")]
[AcceptEmptyServiceProvider]
public sealed class BindingCondition : Condition, IValueProvider
public sealed class BindingCondition : Condition
{
readonly BindableProperty _boundProperty;

Expand Down Expand Up @@ -48,12 +46,6 @@ public object Value
}
}

object IValueProvider.ProvideValue(IServiceProvider serviceProvider)
{
//This is no longer required
return this;
}

internal override bool GetState(BindableObject bindable)
{
object newValue = bindable.GetValue(_boundProperty);
Expand Down
10 changes: 1 addition & 9 deletions src/Controls/src/Core/Interactivity/DataTrigger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ namespace Microsoft.Maui.Controls
{
/// <include file="../../../docs/Microsoft.Maui.Controls/DataTrigger.xml" path="Type[@FullName='Microsoft.Maui.Controls.DataTrigger']/Docs/*" />
[ContentProperty("Setters")]
[ProvideCompiled("Microsoft.Maui.Controls.XamlC.PassthroughValueProvider")]
[AcceptEmptyServiceProvider]
public sealed class DataTrigger : TriggerBase, IValueProvider
public sealed class DataTrigger : TriggerBase
{
/// <include file="../../../docs/Microsoft.Maui.Controls/DataTrigger.xml" path="//Member[@MemberName='.ctor']/Docs/*" />
public DataTrigger([System.ComponentModel.TypeConverter(typeof(TypeTypeConverter))][Parameter("TargetType")] Type targetType) : base(new BindingCondition(), targetType)
Expand Down Expand Up @@ -53,11 +51,5 @@ public object Value
OnPropertyChanged();
}
}

object IValueProvider.ProvideValue(IServiceProvider serviceProvider)
{
//This is no longer required
return this;
}
}
}
10 changes: 1 addition & 9 deletions src/Controls/src/Core/Interactivity/PropertyCondition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
namespace Microsoft.Maui.Controls
{
/// <include file="../../../docs/Microsoft.Maui.Controls/PropertyCondition.xml" path="Type[@FullName='Microsoft.Maui.Controls.PropertyCondition']/Docs/*" />
[ProvideCompiled("Microsoft.Maui.Controls.XamlC.PassthroughValueProvider")]
[AcceptEmptyServiceProvider]
public sealed class PropertyCondition : Condition, IValueProvider
public sealed class PropertyCondition : Condition
{
readonly BindableProperty _stateProperty;

Expand Down Expand Up @@ -84,12 +82,6 @@ public object Value
}
}

object IValueProvider.ProvideValue(IServiceProvider serviceProvider)
{
//This is no longer required
return this;
}

internal override bool GetState(BindableObject bindable)
{
return (bool)bindable.GetValue(_stateProperty);
Expand Down
10 changes: 1 addition & 9 deletions src/Controls/src/Core/Interactivity/Trigger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ namespace Microsoft.Maui.Controls
{
/// <include file="../../../docs/Microsoft.Maui.Controls/Trigger.xml" path="Type[@FullName='Microsoft.Maui.Controls.Trigger']/Docs/*" />
[ContentProperty("Setters")]
[ProvideCompiled("Microsoft.Maui.Controls.XamlC.PassthroughValueProvider")]
[AcceptEmptyServiceProvider]
public sealed class Trigger : TriggerBase, IValueProvider
public sealed class Trigger : TriggerBase
{
/// <include file="../../../docs/Microsoft.Maui.Controls/Trigger.xml" path="//Member[@MemberName='.ctor']/Docs/*" />
public Trigger([System.ComponentModel.TypeConverter(typeof(TypeTypeConverter))][Parameter("TargetType")] Type targetType) : base(new PropertyCondition(), targetType)
Expand Down Expand Up @@ -53,11 +51,5 @@ public object Value
OnPropertyChanged();
}
}

object IValueProvider.ProvideValue(IServiceProvider serviceProvider)
{
//This is no longer required
return this;
}
}
}