Fix up relevant CA1416 warnings - Set 2#26724
Merged
jfversluis merged 4 commits intodotnet:mainfrom Jan 25, 2025
Merged
Conversation
vishnumenon2684
added
the
partner/syncfusion
Tamilarasan-Paranthaman
requested review from
StephaneDelcroix and
tj-devel709
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jfversluis
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
The CA1416 warnings were already resolved in PR #26593
In this PR, we have broken down the file changes from the previous PR into smaller groups and added test cases for the affected areas to ensure proper functionality.
Additionally, I encountered an issue with the changes in the SwipeView file, where the image set in the SwipeView was drawn upside down. I resolved this by adjusting the coordinate system.
maui/src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cs
Line 169 in 8a1815a