Skip to content

[Windows] Fix titlebar not being added to modals#26735

Merged
PureWeen merged 1 commit intomainfrom
foda/TitlebarNavModal
Dec 23, 2024
Merged

[Windows] Fix titlebar not being added to modals#26735
PureWeen merged 1 commit intomainfrom
foda/TitlebarNavModal

Conversation

@Foda
Copy link
Copy Markdown
Contributor

@Foda Foda commented Dec 19, 2024

Description of Change

Fixed the titlebar not being inherited on modals via Navigation.PushModalAsync

Issues Fixed

Fixes #26690

Copilot AI review requested due to automatic review settings December 19, 2024 20:08
@Foda Foda requested a review from a team as a code owner December 19, 2024 20:08
@Foda Foda requested review from rmarinho and tj-devel709 December 19, 2024 20:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@PureWeen PureWeen added this to the .NET 9 SR2.2 milestone Dec 19, 2024
@PureWeen
Copy link
Copy Markdown
Member

PureWeen commented Dec 23, 2024

  • manual test has been added to validate this behavior
  • failing test unrelated

@PureWeen PureWeen merged commit 7ea9ddf into main Dec 23, 2024
@PureWeen PureWeen deleted the foda/TitlebarNavModal branch December 23, 2024 22:18
@PureWeen
Copy link
Copy Markdown
Member

/backport to release/9.0.1xx-sr2

@github-actions
Copy link
Copy Markdown
Contributor

Started backporting to release/9.0.1xx-sr2: https://github.com/dotnet/maui/actions/runs/12473666150

@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Starting from 9.0.12 TitleBar Missing From Modal Pages

3 participants