[iOS] [Android] Fix for the FontImageSource color is not applied properly to the Tab Icon

src/Controls/src/Core/Compatibility/iOS/Extensions/ToolbarItemExtensions.cs

@@ -114,10 +114,6 @@ void UpdateIconAndStyle(ToolbarItem item)
 					{
 						Image = result?.Value;
 						Style = UIBarButtonItemStyle.Plain;
-						if (item.IconImageSource is FontImageSource fontImageSource && fontImageSource.Color is not null)
-						{
-							TintColor = fontImageSource.Color.ToPlatform();
-						}
 					});
 				}
 			}

src/Controls/src/Core/Platform/Android/TabbedPageManager.cs

@@ -10,6 +10,8 @@
 using Android.Views;
 using AndroidX.AppCompat.Widget;
 using AndroidX.CoordinatorLayout.Widget;
+using AndroidX.Core.Content;
+using AndroidX.Core.Graphics;
 using AndroidX.Fragment.App;
 using AndroidX.ViewPager2.Widget;
 using Google.Android.Material.AppBar;
@@ -386,7 +388,7 @@ void TabSelected(TabLayout.Tab tab)
 			if (Element.Children.Count > selectedIndex && selectedIndex >= 0)
 				Element.CurrentPage = Element.Children[selectedIndex];
 
-			SetIconColorFilter(tab, true);
+			SetIconColorFilter(Element.CurrentPage, tab, true);
 		}
 
 		void TeardownPage(Page page)
@@ -525,10 +527,10 @@ void UpdateTabIcons()
 			}
 		}
 
-		protected virtual void SetTabIconImageSource(TabLayout.Tab tab, Drawable icon)
+		protected virtual void SetTabIconImageSource(Page page, TabLayout.Tab tab, Drawable icon)
 		{
 			tab.SetIcon(icon);
-			SetIconColorFilter(tab);
+			SetIconColorFilter(page, tab);
 		}
 
 		void SetTabIconImageSource(Page page, TabLayout.Tab tab)
@@ -537,7 +539,7 @@ void SetTabIconImageSource(Page page, TabLayout.Tab tab)
 				_context,
 				result =>
 				{
-					SetTabIconImageSource(tab, result?.Value);
+					SetTabIconImageSource(page, tab, result?.Value);
 				});
 		}
 
@@ -655,76 +657,94 @@ protected virtual ColorStateList GetItemTextColorStates()
 
 		protected virtual ColorStateList GetItemIconTintColorState()
 		{
-			if (IsBottomTabPlacement)
+			if (_orignalTabIconColors is null)
 			{
-				if (_orignalTabIconColors is null)
-					_orignalTabIconColors = _bottomNavigationView.ItemIconTintList;
+				_orignalTabIconColors = IsBottomTabPlacement ? _bottomNavigationView.ItemIconTintList : _tabLayout.TabIconTint;
 			}
-			// this ensures that existing behavior doesn't change
-			else if (!IsBottomTabPlacement && BarSelectedItemColor != null && BarItemColor == null)
-				return null;
 
 			Color barItemColor = BarItemColor;
 			Color barSelectedItemColor = BarSelectedItemColor;
 
-			if (barItemColor == null && barSelectedItemColor == null)
+			if (barItemColor is null && barSelectedItemColor is null)
+			{
 				return _orignalTabIconColors;
+			}
 
-			if (_newTabIconColors != null)
+			if (_newTabIconColors is not null)
+			{
 				return _newTabIconColors;
+			}
 
 			int defaultColor;
+			int checkedColor;
 
 			if (barItemColor is not null)
 			{
 				defaultColor = barItemColor.ToPlatform().ToArgb();
 			}
 			else
 			{
-#pragma warning disable XAOBS001 // Obsolete
-				var styledAttributes =
-					TintTypedArray.ObtainStyledAttributes(_context.Context, null, Resource.Styleable.NavigationBarView, Resource.Attribute.bottomNavigationStyle, 0);
-#pragma warning restore XAOBS001 // Obsolete
+				defaultColor = GetDefaultColor();
+			}
+
+			if (barSelectedItemColor is not null)
+			{
+				checkedColor = barSelectedItemColor.ToPlatform().ToArgb();
+			}
+			else
+			{
+				checkedColor = GetDefaultColor();
+			}
+
+			_newTabIconColors = GetColorStateList(defaultColor, checkedColor);
+			return _newTabIconColors;
+		}
 
-				try
+		int GetDefaultColor()
+		{
+			int defaultColor;
+			var styledAttributes =
+				_context.Context.Theme.ObtainStyledAttributes(
+					null,
+					Resource.Styleable.NavigationBarView,
+					Resource.Attribute.bottomNavigationStyle,
+					0);
+
+			try
+			{
+				var defaultColors = styledAttributes.GetColorStateList(Resource.Styleable.NavigationBarView_itemIconTint);
+				if (defaultColors is not null)
+				{
+					defaultColor = defaultColors.DefaultColor;
+				}
+				else
 				{
-					var defaultColors = styledAttributes.GetColorStateList(Resource.Styleable.NavigationBarView_itemIconTint);
-					if (defaultColors is not null)
+					// These are the defaults currently set inside android
+					// It's very unlikely we'll hit this path because the 
+					// NavigationBarView_itemIconTint should always resolve
+					// But just in case, we'll just hard code to some defaults
+					// instead of leaving the application in a broken state
+					if (IsDarkTheme)
 					{
-						defaultColor = defaultColors.DefaultColor;
+						defaultColor = ColorUtils.SetAlphaComponent(
+							ContextCompat.GetColor(_context.Context, Resource.Color.primary_dark_material_light),
+							153); // 60% opacity
 					}
 					else
 					{
-						// These are the defaults currently set inside android
-						// It's very unlikely we'll hit this path because the 
-						// NavigationBarView_itemIconTint should always resolve
-						// But just in case, we'll just hard code to some defaults
-						// instead of leaving the application in a broken state
-						if (IsDarkTheme)
-							defaultColor = new Color(1, 1, 1, 0.6f).ToPlatform();
-						else
-							defaultColor = new Color(0, 0, 0, 0.6f).ToPlatform();
+						defaultColor = ColorUtils.SetAlphaComponent(
+							ContextCompat.GetColor(_context.Context, Resource.Color.primary_dark_material_dark),
+							153); // 60% opacity
 					}
 				}
-				finally
-				{
-					styledAttributes.Recycle();
-				}
 			}
-
-			if (barItemColor == null && _orignalTabIconColors != null)
-				defaultColor = _orignalTabIconColors.DefaultColor;
-
-			int checkedColor = defaultColor;
-
-			if (barSelectedItemColor != null)
-				checkedColor = barSelectedItemColor.ToPlatform().ToArgb();
-
-			_newTabIconColors = GetColorStateList(defaultColor, checkedColor);
-			return _newTabIconColors;
+			finally
+			{
+				styledAttributes.Recycle();
+			}
+			return defaultColor;
 		}
 
-
 		void OnMoreSheetDismissed(object sender, EventArgs e)
 		{
 			var index = Element.Children.IndexOf(Element.CurrentPage);
@@ -759,11 +779,11 @@ void UpdateItemIconColor()
 				_bottomNavigationView.ItemIconTintList = GetItemIconTintColorState() ?? _orignalTabIconColors;
 			else
 			{
-				var colors = GetItemIconTintColorState() ?? _orignalTabIconColors;
 				for (int i = 0; i < _tabLayout.TabCount; i++)
 				{
 					TabLayout.Tab tab = _tabLayout.GetTabAt(i);
-					this.SetIconColorFilter(tab);
+					var page = Element.Children[i];
+					this.SetIconColorFilter(page, tab);
 				}
 			}
 		}
@@ -802,18 +822,18 @@ void UpdateBarTextColor()
 				_tabLayout.TabTextColors = _currentBarTextColorStateList;
 		}
 
-		void SetIconColorFilter(TabLayout.Tab tab)
+		void SetIconColorFilter(Page page, TabLayout.Tab tab)
 		{
-			SetIconColorFilter(tab, _tabLayout.GetTabAt(_tabLayout.SelectedTabPosition) == tab);
+			SetIconColorFilter(page, tab, _tabLayout.GetTabAt(_tabLayout.SelectedTabPosition) == tab);
 		}
 
-		void SetIconColorFilter(TabLayout.Tab tab, bool selected)
+		void SetIconColorFilter(Page page, TabLayout.Tab tab, bool selected)
 		{
 			var icon = tab.Icon;
 			if (icon == null)
 				return;
 
-			var colors = GetItemIconTintColorState();
+			ColorStateList colors = (page.IconImageSource is FontImageSource fontImageSource && fontImageSource.Color is not null) ? null : GetItemIconTintColorState();
 			if (colors == null)
 				ADrawableCompat.SetTintList(icon, null);
 			else
@@ -989,8 +1009,8 @@ void TabLayout.IOnTabSelectedListener.OnTabSelected(TabLayout.Tab tab)
 
 			void TabLayout.IOnTabSelectedListener.OnTabUnselected(TabLayout.Tab tab)
 			{
-				_tabbedPageManager.SetIconColorFilter(tab, false);
+				_tabbedPageManager.SetIconColorFilter(_tabbedPageManager.Element.CurrentPage, tab, false);
 			}
 		}
 	}
-}
+}

src/Controls/tests/TestCases.HostApp/Issues/Issue26662.xaml

@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<TabbedPage
+    xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
+    xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
+    SelectedTabColor="Green"
+    UnselectedTabColor="gray"
+    xmlns:local="clr-namespace:Maui.Controls.Sample.Issues"
+    x:Class="Maui.Controls.Sample.Issues.Issue26662">
+
+    <local:Issue26662Tab1/>
+    <local:Issue26662Tab2/>
+    <local:Issue26662Tab3/>
+
+</TabbedPage>

src/Controls/tests/TestCases.HostApp/Issues/Issue26662.xaml.cs

@@ -0,0 +1,112 @@
+namespace Maui.Controls.Sample.Issues
+{
+	[Issue(IssueTracker.Github, 26662, "Unable to dynamically set unselected IconImageSource Color on Android", PlatformAffected.All)]
+	public partial class Issue26662 : TabbedPage
+	{
+		public Issue26662()
+		{
+			InitializeComponent();
+		}
+
+	}
+
+	public class Issue26662Tab1 : ContentPage
+	{
+		public Issue26662Tab1()
+		{
+			//If no FontImageSource color is given, tab icon should be applied based on the SelectedTabColor and UnselectedTabColor.
+			IconImageSource = new FontImageSource
+			{
+				FontFamily = "Ion",
+				Glyph = "\uf30c",
+				Size = 15
+			};
+			Button button = new Button
+			{
+				Text = "Change Icon Color",
+				BackgroundColor = Colors.Blue,
+				TextColor = Colors.Red
+			};
+			button.AutomationId = "Button";
+			button.Clicked += (s, e) =>
+			{
+				//If the FontImageSource color is given, the tab icon color should be applied solely based on the specified color, regardless of the SelectedTabColor or UnselectedTabColor.
+				(this.IconImageSource as FontImageSource).Color = Colors.Violet;
+			};
+			Title = "Tab 1";
+			var verticalStackLayout = new VerticalStackLayout
+			{
+				VerticalOptions = LayoutOptions.Center,
+				Children = {
+					new Label
+						{
+							HorizontalOptions = LayoutOptions.Center,
+							Text = "Tab 1"
+						},
+						button
+					}
+
+			};
+			Content = verticalStackLayout;
+		}
+	}
+
+	public class Issue26662Tab2 : ContentPage
+	{
+		public Issue26662Tab2()
+		{
+			//The FontImageSource color is given. So, the tab icon color should be applied based solely on the given color, regardless of the selected tab or unselected tab color.
+			IconImageSource = new FontImageSource
+			{
+				FontFamily = "Ion",
+				Glyph = "\uf30c",
+				Color = Colors.DodgerBlue,
+				Size = 15
+			};
+
+			Title = "Tab 2";
+			var verticalStackLayout = new VerticalStackLayout
+			{
+				VerticalOptions = LayoutOptions.Center,
+				Children =
+					{
+						new Label
+							{
+								HorizontalOptions = LayoutOptions.Center,
+								Text = "Tab 2"
+							},
+					}
+			};
+			Content = verticalStackLayout;
+		}
+	}
+	public class Issue26662Tab3 : ContentPage
+	{
+		public Issue26662Tab3()
+		{
+			//The FontImageSource color is given. So, the icon color should be applied based solely on the given color, regardless of the selected tab or unselected tab color.
+			IconImageSource = new FontImageSource
+			{
+				FontFamily = "Ion",
+				Glyph = "\uf30c",
+				Color = Colors.Red,
+				Size = 15
+			};
+
+			Title = "Tab 3";
+			var verticalStackLayout = new VerticalStackLayout
+			{
+				VerticalOptions = LayoutOptions.Center,
+				Children =
+					{
+						new Label
+							{
+								HorizontalOptions = LayoutOptions.Center,
+								Text = "Tab 3"
+							},
+					}
+			};
+			Content = verticalStackLayout;
+		}
+	}
+}