Skip to content

Fix for [Windows]ToolbarItem visibility until Page Disappearing #26915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 10 commits into from
Feb 7, 2025
Merged

Fix for [Windows]ToolbarItem visibility until Page Disappearing #26915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d54d1c3
fix for 23608
SuthiYuvaraj Jan 2, 2025
5c20e87
Update Toolbar.Windows.cs
SuthiYuvaraj Jan 2, 2025
3eab101
Commit for 23698
SuthiYuvaraj Jan 6, 2025
afc8e8b
Merge branch 'dotnet:main' into fix-23608
SuthiYuvaraj Jan 6, 2025
03b6c31
unwanted changes
SuthiYuvaraj Jan 6, 2025
59ef9f8
Commit for unwanted changes
SuthiYuvaraj Jan 13, 2025
b7be2b8
Update ItemsViewLayout.cs
SuthiYuvaraj Jan 13, 2025
f428f5e
Update ItemsViewLayout.cs
SuthiYuvaraj Jan 13, 2025
67ea1dd
Update ItemsViewLayout.cs
SuthiYuvaraj Jan 13, 2025
923a3da
Update Issue9419.cs
SuthiYuvaraj Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Controls/src/Core/Toolbar/Toolbar.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ internal void UpdateMenu()

internal void OnToolbarItemPropertyChanged(object? sender, PropertyChangedEventArgs e)
{
if (Handler.PlatformView is not MauiToolbar wh)
if (Handler?.PlatformView is not MauiToolbar wh)
return;

var commandBar = wh.CommandBar;
Expand Down
4 changes: 1 addition & 3 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue9419.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if TEST_FAILS_ON_WINDOWS //App Crashes on windows, Issue: https://github.com/dotnet/maui/issues/26803
using NUnit.Framework;
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

Expand All @@ -23,4 +22,3 @@ public void TestIssue9419()
}
}
}
#endif