Skip to content

[iOS] Fix for Left SwipeView Items Conflict with Shell Menu Swipe Gesture#26976

Merged
PureWeen merged 3 commits intodotnet:mainfrom
Tamilarasan-Paranthaman:fix-26933
Jan 30, 2025
Merged

[iOS] Fix for Left SwipeView Items Conflict with Shell Menu Swipe Gesture#26976
PureWeen merged 3 commits intodotnet:mainfrom
Tamilarasan-Paranthaman:fix-26933

Conversation

@Tamilarasan-Paranthaman
Copy link
Copy Markdown
Member

Root Cause of the issue

  • When swiping to the left in the SwipeView, the shell flyout gesture intercepts the SwipeView gesture and causes the shell flyout to open.

Description of Change

  • I resolved the issue by identifying if the view is a MauiSwipeView. If it is, I restricted the touch interaction in the shell flyout, allowing the SwipeView touch gestures to work as expected.

Issues Fixed

Fixes #26933

Tested the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Screenshot

Before Issue Fix After Issue Fix
SwipeViewIssue.mov
SwipeViewFix.mov

Reference from Xamarin

https://github.com/xamarin/Xamarin.Forms/blob/2f8f4864a4d289dc89a6228e2ca9d6a49993e365/Xamarin.Forms.Platform.iOS/Renderers/ShellFlyoutRenderer.cs#L85

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 7, 2025
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Hey there @Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@karthikraja-arumugam karthikraja-arumugam added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jan 7, 2025
@rmarinho
Copy link
Copy Markdown
Member

rmarinho commented Jan 7, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@Tamilarasan-Paranthaman Tamilarasan-Paranthaman marked this pull request as ready for review January 7, 2025 13:28
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman requested a review from a team as a code owner January 7, 2025 13:28
@jfversluis jfversluis added the area-controls-shell Shell Navigation, Routes, Tabs, Flyout label Jan 9, 2025
@jsuarezruiz
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen dismissed jsuarezruiz’s stale review January 30, 2025 18:46

Changes addressed

@PureWeen PureWeen merged commit 91aada4 into dotnet:main Jan 30, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-shell Shell Navigation, Routes, Tabs, Flyout community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Left SwipeView Items Conflict with Shell Menu Swipe Gesture on iOS

6 participants