Skip to content

[iOS] Fixed the Application crash when ToolbarItem is created with invalid IconImageSource name #27175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmarinho merged 1 commit into from
Feb 17, 2025
Merged

[iOS] Fixed the Application crash when ToolbarItem is created with invalid IconImageSource name #27175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue2222.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if TEST_FAILS_ON_IOS //Application crashes when ToolbarItem is created with invalid IconImageSource name.Issue Link: https://github.com/dotnet/maui/issues/27095
using NUnit.Framework;
using NUnit.Framework;
Copy link
Copy Markdown
Contributor

@jsuarezruiz jsuarezruiz Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens on other platforms? Based on the test, guess not throwing an exception, right?

Copy link
Copy Markdown
Contributor Author

@Ahamed-Ali Ahamed-Ali Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An exception is not thrown on other platforms when an invalid IconImageSource name is provided @jsuarezruiz

using UITest.Appium;
using UITest.Core;

Expand All @@ -20,5 +19,4 @@ public void TestItDoesntCrashWithWrongIconName()
App.WaitForElement("TestLabel");
}
}
}
#endif
}
2 changes: 1 addition & 1 deletion src/Core/src/ImageSources/FileImageSourceService/FileImageSourceService.iOS.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public partial class FileImageSourceService
{
Logger?.LogWarning(ex, "Unable to load image file '{File}'.", imageSource.File);

throw;
Copy link
Copy Markdown
Contributor

@jsuarezruiz jsuarezruiz Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattleibow I understand that throwing the exception at this point was a expected behavior, right?

return FromResult(null);
Copy link
Copy Markdown
Contributor

@jsuarezruiz jsuarezruiz Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on https://github.com/dotnet/maui/pull/27175/files#r1939317042
This align the behavior between platforms. LGTM.

}
}

Expand Down