Skip useless handler mappings calls while connecting#27259
Merged
PureWeen merged 5 commits intodotnet:inflight/currentfrom Jun 27, 2025
Merged
Conversation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This is an alternative initial version of #27042.
Everything has already been explained there.
Based on/includes #28077 PR
Credits to @MartyIX to have explored the effectiveness of skipping specific mappers.
Key differences from the other PR:
IElementandIElementHandlerto get the handler stateMappingFrametakes care of all the coordinates, even translations, while on other platforms the situation is different)Benchmark using Nalu Weather app
https://github.com/nalu-development/nalu/tree/main/Samples/Nalu.Maui.Weather
Click on the links in the table to download the speedscope.json file.
SetVirtualView(SR4)SetVirtualView(PR)Thanks to @MartyIX for collecting speedscopes on Windows!
Benchmark (from CI - on iOS UI tests)
Note: there is some variability in the benchmark caused by the runner itself, but looking at many recent PRs,
mainbranch never goes under 2600ms.mainbranch#27042 original PR
this

PRIssues Fixed
Fixes #17303