Fixed Picker Items are not Displaying on macOS platform by NanthiniMahalingam · Pull Request #27535 · dotnet/maui

NanthiniMahalingam · 2025-02-03T12:57:07Z

Issue Details

Picker view items are not displayed when setting the title on the picker control.

Root Cause

The picker view does not appear when passing the virtual view title parameter while creating the UIAlertController title on the Mac Catalyst platform.

Description of Change

The UIPickerView items are displayed in the picker control instead of showing the picker's title in UIAlertController when tapping on the picker by passing an empty string to the UIAlertController title parameter.

Issues Fixed

Fixes #27474,
Fixes #15954,
Fixes #18015

Validated the behaviour in the following platforms

Android
Windows
iOS
Mac

Output

macOS platform

Before	After
mac_Before_27474.mov	mac_After_27474.mov

dotnet-policy-service · 2025-02-03T13:09:27Z

Hey there @NanthiniMahalingam! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

jsuarezruiz · 2025-02-03T14:54:00Z

/azp run

azure-pipelines · 2025-02-03T14:54:24Z

Azure Pipelines successfully started running 3 pipeline(s).

Copilot

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

jsuarezruiz · 2025-02-05T12:04:21Z

/azp run

azure-pipelines · 2025-02-05T12:04:42Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-02-06T07:38:55Z

/azp run

azure-pipelines · 2025-02-06T07:39:12Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-02-12T10:42:38Z

/rebase

StephaneDelcroix · 2025-02-13T08:24:08Z

src/Core/src/Handlers/Picker/PickerHandler.iOS.cs

 			pickerView?.ReloadAllComponents();

-			var pickerController = UIAlertController.Create(VirtualView.Title, "", UIAlertControllerStyle.ActionSheet);
+			var pickerController = UIAlertController.Create("", "", UIAlertControllerStyle.ActionSheet);


this doesn't look like a proper fix, but a hack to get it working

Hi @StephaneDelcroix ,

On the macOS native platform, when setting the title in a UIAlertController, only the title is displayed, rather than any subview added to the UIAlertController.

However, when setting an empty string as the title in UIAlertController, the added subview is displayed as expected.

Similarly, in the .NET MAUI macOS platform, a UIAlertController displays a UIPickerView added as a subview. When setting the title as an empty string, the UIPickerView subview behaves like its native macOS.

StephaneDelcroix · 2025-02-13T08:25:02Z

title and logo are gone in the 'after'. is this what we want ?

NanthiniMahalingam · 2025-02-14T06:15:31Z

title and logo are gone in the 'after'. is this what we want ?

Hi @StephaneDelcroix Yes, we want the picker items to be displayed without the title and logo.

jsuarezruiz · 2025-03-07T07:44:06Z

/rebase

jsuarezruiz · 2025-03-11T11:59:04Z

/azp run

azure-pipelines · 2025-03-11T11:59:25Z

Azure Pipelines successfully started running 3 pipeline(s).

Added the output image on windows platform

jsuarezruiz · 2025-03-18T08:55:56Z

/azp run

azure-pipelines · 2025-03-18T08:56:17Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-03-21T13:03:26Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue27474.cs

+
+        [Test]
+        [Category(UITestCategories.Picker)]
+        public void ShouldDisplayPickerItemsWhenOpeningPicker()


The test is failing on Mac because the reference snapshot is pending. Already available in the latest build.

Could you commit it?

The test is failing on Mac because the reference snapshot is pending. Already available in the latest build. Could you commit it?

I've committed the macOS output image. Could you please verify it?

…into fix-27474

jsuarezruiz · 2025-03-24T08:00:02Z

/azp run

azure-pipelines · 2025-03-24T08:01:23Z

Azure Pipelines successfully started running 3 pipeline(s).

src/Core/src/Handlers/Picker/PickerHandler.iOS.cs

jsuarezruiz · 2025-05-09T07:28:53Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-09T07:29:05Z

Azure Pipelines successfully started running 1 pipeline(s).

src/Core/src/Handlers/Picker/PickerHandler.iOS.cs

bhavanesh2001

Bump

review taken care of

* Fixed the picker view items source does not display on mac platform * Added the test case * Added the output images. * Fixed the picker view items source does not display on mac platform * Added the test case * Added the output images. * Create ShouldDisplayPickerItemsWhenOpeningPicker.png Added the output image on windows platform * Ignore the test case on catalyst platform * Added the test case for mac platform * Added the macOS output image * Added the comment line for fix.

NanthiniMahalingam added 4 commits February 3, 2025 12:15

Fixed the picker view items source does not display on mac platform

c64f6fc

Added the test case

0c2ed2d

Added the output images.

d8fd1be

Merge remote-tracking branch 'upstream/main' into fix-27474

d200887

dotnet-policy-service bot added the community ✨ Community Contribution label Feb 3, 2025

vishnumenon2684 added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Feb 3, 2025

jsuarezruiz added the area-controls-picker Picker label Feb 3, 2025

jsuarezruiz added the platform/macos macOS / Mac Catalyst label Feb 3, 2025

NanthiniMahalingam marked this pull request as ready for review February 4, 2025 11:44

Copilot AI review requested due to automatic review settings February 4, 2025 11:44

NanthiniMahalingam requested a review from a team as a code owner February 4, 2025 11:44

NanthiniMahalingam requested review from PureWeen and tj-devel709 February 4, 2025 11:44

Copilot AI reviewed Feb 4, 2025

View reviewed changes

github-actions bot force-pushed the fix-27474 branch from 0cac32a to c4c4b02 Compare February 12, 2025 10:43

StephaneDelcroix previously requested changes Feb 13, 2025

View reviewed changes

github-actions bot force-pushed the fix-27474 branch from c4c4b02 to ea4d6cb Compare March 7, 2025 07:44

NanthiniMahalingam added 4 commits March 18, 2025 08:53

Added the output images.

e9d39ad

Create ShouldDisplayPickerItemsWhenOpeningPicker.png

3e03701

Added the output image on windows platform

Ignore the test case on catalyst platform

d401e0f

Added the test case for mac platform

0d996ad

github-actions bot force-pushed the fix-27474 branch from ea4d6cb to 0d996ad Compare March 18, 2025 08:53

jsuarezruiz suggested changes Mar 21, 2025

View reviewed changes

NanthiniMahalingam added 2 commits March 21, 2025 19:58

Added the macOS output image

f5942cb

Merge branch 'fix-27474' of https://github.com/NanthiniMahalingam/maui …

41ebe9c

…into fix-27474

jsuarezruiz suggested changes Apr 16, 2025

View reviewed changes

src/Core/src/Handlers/Picker/PickerHandler.iOS.cs Show resolved Hide resolved

Added the comment line for fix.

bd92cba

jsuarezruiz suggested changes May 12, 2025

View reviewed changes

src/Core/src/Handlers/Picker/PickerHandler.iOS.cs Show resolved Hide resolved

jsuarezruiz approved these changes May 16, 2025

View reviewed changes

bhavanesh2001 approved these changes Aug 5, 2025

View reviewed changes

PureWeen changed the base branch from main to inflight/current August 7, 2025 21:48

PureWeen merged commit b51d4e8 into dotnet:inflight/current Aug 7, 2025
81 checks passed

PureWeen added this to the .NET 9 SR11 milestone Aug 8, 2025

github-actions bot locked and limited conversation to collaborators Sep 8, 2025

Conversation

NanthiniMahalingam commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Details

Root Cause

Description of Change

Issues Fixed

Output

Uh oh!

dotnet-policy-service bot commented Feb 3, 2025

Uh oh!

jsuarezruiz commented Feb 3, 2025

Uh oh!

azure-pipelines bot commented Feb 3, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Feb 5, 2025

Uh oh!

azure-pipelines bot commented Feb 5, 2025

Uh oh!

jsuarezruiz commented Feb 6, 2025

Uh oh!

azure-pipelines bot commented Feb 6, 2025

Uh oh!

jsuarezruiz commented Feb 12, 2025

Uh oh!

StephaneDelcroix Feb 13, 2025

Choose a reason for hiding this comment

Uh oh!

NanthiniMahalingam Feb 13, 2025

Choose a reason for hiding this comment

Uh oh!

StephaneDelcroix commented Feb 13, 2025

Uh oh!

NanthiniMahalingam commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsuarezruiz commented Mar 7, 2025

Uh oh!

jsuarezruiz commented Mar 11, 2025

Uh oh!

azure-pipelines bot commented Mar 11, 2025

Uh oh!

jsuarezruiz commented Mar 18, 2025

Uh oh!

azure-pipelines bot commented Mar 18, 2025

Uh oh!

jsuarezruiz Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

NanthiniMahalingam Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Mar 24, 2025

Uh oh!

azure-pipelines bot commented Mar 24, 2025

Uh oh!

Uh oh!

jsuarezruiz commented May 9, 2025

Uh oh!

azure-pipelines bot commented May 9, 2025

Uh oh!

Uh oh!

bhavanesh2001 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

NanthiniMahalingam commented Feb 3, 2025 •

edited

Loading

NanthiniMahalingam commented Feb 14, 2025 •

edited

Loading